Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveMetrics Filtering Part 2: Configuration #43184

Merged
merged 45 commits into from
Dec 6, 2024
Merged

LiveMetrics Filtering Part 2: Configuration #43184

merged 45 commits into from
Dec 6, 2024

Conversation

harsimar
Copy link
Member

@harsimar harsimar commented Dec 3, 2024 •
edited
Loading

Description

  • FilteringConfiguration.java: this stores the config in a format that is easy for QuickPulseDataCollector to retrieve.
  • QuickPulsePingSender/DataSender to update FilteringConfiguration.java whenever the filtering configuration changes. QuickPulse apis send filtering configuration via ping/post response bodies and the etag is what identifies a new config. The etag from a response is used to populate the etag header on future post requests.
  • QuickPulseDataCollector has some commented out code blocks with TODOs that demonstrate how the filtering configuration would be used in order to apply filtering logic. These TODOs will be implemented in the next PR.
  • I am also addressing a small comment from a previous PR in this one about getters/setters in CustomDimensions.java. One more commit upcoming for this.

harsimar and others added 30 commits October 10, 2024 15:23
@harsimar
swagger
8166d23
@harsimar
experimenting with ping api, not done yet
af3c368
@harsimar
experimental code, post not done, not tested
84fbbec
@harsimar
initial draft and test changes
c0a80c2
@harsimar
changes to build point
39a88cc
@harsimar
Merge branch 'main' into harskaur/swaggerQP
614e92c
@harsimar
fix some bugs, fix some tests
c65e2f4
@harsimar
cleanup & test fixes
179f188
@harsimar
minor changes I forgot to push
8dee280
@harsimar
a slight restructuring and adding yaml/licence headers
d069513
@trask
Merge remote-tracking branch 'upstream/main' into harskaur/swaggerQP
72d00e1
@trask
Migrate changes to the new autoconfigure module (#42864)
f4d2545 
* move

* markdown

* check
@harsimar
delete unused files and remove version from yaml
9ec9fd5
@harsimar
starting to port stuff, incomplete
892685f
@harsimar
more code, not done
afa4f8a
@harsimar
updating some comments according to pr review
ec4137a
@harsimar
starting to add test, test is failing
153efc0
@harsimar
PR comment
68fecf5
@harsimar
trying to fix build error
76bcc0a
@harsimar
minor
d360d8a
@harsimar
Merge branch 'main' into harskaur/swaggerQP
03ccbe6
@harsimar
hopefully this should fix build analyze step errors
8dc3d5d
@harsimar
Merge branch 'harskaur/swaggerQP' into harskaur/filterP1
c280425
@harsimar
added custom dim test, need to debug
56756e5
@harsimar
adding more tests
af327ef
@harsimar
final changes
6d54081
@harsimar
merge from main
9d50951
@harsimar
pr comment & fixing CI build errors
c577ae5
@harsimar
pr comments
ade36fa
@harsimar
start
d6d709f
@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Dec 3, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

jeanbisutti
jeanbisutti reviewed Dec 5, 2024
View reviewed changes
@harsimar harsimar marked this pull request as ready for review December 6, 2024 17:37
@harsimar harsimar merged commit ea552e6 into main Dec 6, 2024
23 checks passed
@harsimar harsimar deleted the harskaur/filteringP2 branch December 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@heyams heyams Awaiting requested review from heyams heyams is a code owner

Assignees
No one assigned
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsimar @azure-sdk @trask @jeanbisutti