Skip to content

Support multiple data source prop passwordless and new prop of credential bean name #42486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 31, 2024
Merged

Support multiple data source prop passwordless and new prop of credential bean name #42486

merged 23 commits into from
Oct 31, 2024

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Oct 21, 2024 •
edited
Loading

Description

Fixes #41977

Changelogs:

  • Fix primitive type prop (isManagedIdentityEnabled) copy issue
  • Support multiple data source prop passwordless
  • Add new prop of credential bean name, it's suitable for all SDK client, JMS passworless, Redis passwordless, JDBC passwordless, Spring Integration for Service Bus.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Oct 21, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 21, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@moarychan moarychan marked this pull request as ready for review October 21, 2024 07:34
saragluna
saragluna reviewed Oct 22, 2024
View reviewed changes
saragluna
saragluna reviewed Oct 29, 2024
View reviewed changes
saragluna
saragluna approved these changes Oct 30, 2024
View reviewed changes
@moarychan moarychan merged commit 9532160 into Azure:main Oct 31, 2024
28 checks passed
@moarychan moarychan mentioned this pull request Nov 1, 2024
Merged
6 tasks
@moarychan moarychan deleted the bugfixes/mult-ds-prop-inherit-standalone-prop-and-support-credential-bean-name-prop branch November 20, 2024 08:07
@smiklos smiklos mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@mssfang mssfang Awaiting requested review from mssfang

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Passwordless authentication for RDBMS when multiple data sources are registered
3 participants
@moarychan @azure-sdk @saragluna