Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up POM dependencies #42469

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Oct 18, 2024

Description

Removes the azure-core-http-jdk-httpclient exclusion in the azure-core-test dependency as the issue which caused Java 8 runs to fail when attempting to load the JDK HttpClient, which is compiled targeting Java 11 bytecode, was fixed (refer). This also allowed for the removal of the JDK 12+ profile which added the JDK HttpClient implementation as a dependency.

While inspecting all azure-core-test usages in POMs, POMs were verified for their design and other build, profile, and dependencies were removed.

  • Mockito dependencies were removed from projects that don't actually use Mockito.
  • Configurations for the codesnippet-maven-plugin were removed when they matched the default configuration.
  • Inclusion of sample resources were removed when the project didn't have sample resources.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Untriaged
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants