Fix JDK HttpClient inclusion in testing #42070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao,
ArthurMa1978,
jeanbisutti,
trask,
ramthi,
heyams,
harsimar,
MikeyMCZ,
jairmyree,
vcolin7,
ibrahimrabab,
seanmcc-msft,
ibrandes,
kyleknap,
vicancy,
chenkennt,
zackliu,
anuchandy,
conniey,
lmolkova,
a team,
srnagar,
MichaelZp0 and
ChristopherManthei
as code owners
github-actions
bot
added
OpenTelemetry
|
/azp run java - azure-communication-identity - tests |
|
/azp run java - remoterendering - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run java - azure-communication-identity - tests |
|
/azp run java - remoterendering - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - azure-communication-identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
billwert
approved these changes
Sep 26, 2024
|
/check-enforcer override |
alzimmermsft
deleted the
AzAll_ExcludeJdkHttpClientFromAzureCoreTest
branch
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2024
Fix JDK HttpClient inclusion in testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves an issue where JDK HttpClient would be on the classpath and
HttpClient.createDefaultInstance()would crash an application during testing on Java 8. In a future release ofazure-corethis will be resolved with service provider loading catching certain errors that are related to class loading issues. So, a lot of this PR will be reverted when that change releases, but this is needed for now to resolve testing issues.Note:
azure-core-testhas utility APIs which already handled these issues, but there are many locations in either test code or production code where an HttpClient isn't being configured, forcing those code paths to fallback to usingHttpClient.createDefaultInstance(). These code paths should either be updated to using testing utilities that return theHttpClientimplementation to use for testing or for production code those code paths should be updated to support configuring theHttpClient.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines