File Shares Sync Stack Upload APIs #41664
Conversation
|
API change check API changes are not detected in this pull request. |
...age/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareFileClient.java
Outdated
Show resolved
Hide resolved
…to fileSharesSyncUpload
…to fileSharesSyncUpload
…to fileSharesSyncUpload
| final long blockSize = Math.min(validatedParallelTransferOptions.getBlockSizeLong(), 4L * 1024L * 1024L); // 4 MB | ||
| final int maxConcurrency = validatedParallelTransferOptions.getMaxConcurrency(); | ||
|
|
||
| ExecutorService executor = Executors.newFixedThreadPool(maxConcurrency); |
There was a problem hiding this comment.
Should look into designing this differently, as this will create a new thread pool per API call and will result in many, many Threads being created and torn down. I'd want to look into leveraging SharedExecutorService in azure-core as the thread pool that manages parallelization here, but that generally will have many more threads available than parallelization will be set to, so we'll need to implement some level of rate limiting.
I think we should look initially into limiting the number of calls in parallel by using a Semaphore with a number of permits equal to parallelization (and remembering to release them when that upload chunk is complete).
Description