Update CODEOWNERS #41382
Merged
Update CODEOWNERS #41382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nehrao1
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova,
JonathanGiles,
alzimmermsft and
a team
as code owners
alzimmermsft
approved these changes
Jul 31, 2024
srnagar
approved these changes
Jul 31, 2024
| @@ -341,7 +341,7 @@ | |||
| # ServiceOwners: @kushagraThapar @TheovanKraay @pjohari-ms | |||
|
|
|||
| # PRLabel: %Cosmos | |||
| /sdk/cosmos/ @kushagraThapar @FabianMeiswinkel @kirankumarkolli @xinlian12 @milismsft @aayush3011 @simorenoh @jeet1995 @Pilchie | |||
| /sdk/cosmos/ @kushagraThapar @FabianMeiswinkel @kirankumarkolli @xinlian12 @milismsft @aayush3011 @simorenoh @jeet1995 @Pilchie @nehrao1 | |||
There was a problem hiding this comment.
It might be worth creating a GitHub Team and making that team a codeowner similar to the one we have for other libraries.
See Monitor Team for example. Then, in codeowners file, you can just reference this team. This will allow you to add/remove members without having to update the codeowners file.
There was a problem hiding this comment.
@srnagar interesting, didn't know this. I will look into it.
thanks Srikanta!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding myself to CODEOWNERS for Cosmos SDK.