New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blobs Sync Stack Migration #40812

Merged

ibrahimrabab merged 61 commits into Azure:main from ibrahimrabab:syncStack-blobs

Sep 10, 2024

Contributor

ibrahimrabab commented Jun 25, 2024

Description

Migrating all sync clients in the Blobs package from using async clients to sync-only behavior.

Does not include the migration of uploads/downloads, these methods will be implemented in a future PR.

ibrahimrabab added 4 commits

June 17, 2024 14:52


          autorest generated changes including removal of enable-xml

d8a0417


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

7797a77

…to syncStack-blobs


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

a9586d2

…to syncStack-blobs


          adding all changes for decoupling sync and async client

76c2536

github-actions bot added the Storage label

ibrahimrabab added 20 commits

June 26, 2024 14:29


          fixing logic for findBlobs

d5b0353


          fixing listBlobs include logic

a3c2050


          removing commented line

cf5475c


          using final pageblob request conditions

cb231b2


          fixing getBlobClient in containerclient class


          fixing the async client that created from versionId and snapshot

849c611


          fixed lambda function for listing apis

f889874


          fixing pageList method

6a26ca6


          adding changes from xml removal


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

f87d900

…to syncStack-blobs


          adding xml migration changes

7f70d75


          copying changes from xml migration pr

34b1288


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

80a5b41

…to syncStack-blobs


          removing all references of xmlJackson

c814194


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

cd0e261

…to syncStack-blobs


          updating lease id after aqcuire and change lease

b6efa1d


          fix listing apis and versioning apis

396e6bd


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

a39fe65

…to syncStack-blobs


          fixing listPages and queryWithResponse


          fixed queryWithResponse and queryInputStream tests

db6159a

Collaborator

azure-sdk commented Jul 9, 2024 •

edited

Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-storage-blob
com.azure:azure-storage-file-datalake

alzimmermsft reviewed

View reviewed changes

...e-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/BlobQueryReader.java Outdated Show resolved Hide resolved

...e-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/BlobQueryReader.java Outdated Show resolved Hide resolved

...azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/ModelHelper.java Outdated Show resolved Hide resolved

...azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/ModelHelper.java Outdated Show resolved Hide resolved

sdk/storage/azure-storage-blob/pom.xml Outdated Show resolved Hide resolved

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceClient.java Outdated Show resolved Hide resolved

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerClient.java Outdated Show resolved Hide resolved

sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobContainerClient.java Outdated Show resolved Hide resolved

...rage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobClientBase.java Outdated Show resolved Hide resolved

ibrahimrabab added 3 commits

July 25, 2024 01:39


          Merge remote-tracking branch 'azure' into syncStack-blobs

74ef4b5


          fixing comments from PR

afe670b


          addressing more comments, fixing analyze issues

09ee10d


          updating okhttp version

3380c21

Contributor Author

ibrahimrabab commented Sep 4, 2024

/azp run java - storage - tests

azure-pipelines bot commented Sep 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          updating version_client.txt to use unreleased version of blob and dat…

f7a52b9

…alake

Contributor Author

ibrahimrabab commented Sep 4, 2024

/azp run java - storage - tests

azure-pipelines bot commented Sep 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          updating unreleased versions for core and okhttp

c93d9b0

Contributor Author

ibrahimrabab commented Sep 4, 2024

/azp run java - storage - tests

azure-pipelines bot commented Sep 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).

ibrahimrabab added 2 commits

September 4, 2024 14:51


          fixing unreleased version

592c079


          removing dead method readFromInputStream

d2c2500

Contributor Author

ibrahimrabab commented Sep 4, 2024

/azp run java - storage - tests

azure-pipelines bot commented Sep 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).

ibrahimrabab added 2 commits

September 5, 2024 12:58


          Merge branch 'main' of https://github.com/Azure/azure-sdk-for-java in…

06a97a3

…to syncStack-blobs


          adding checkstyle suppression for impl clients

9358ad0

Contributor Author

ibrahimrabab commented Sep 5, 2024

/azp run java - storage - tests

azure-pipelines bot commented Sep 5, 2024

Azure Pipelines successfully started running 1 pipeline(s).

alzimmermsft approved these changes

View reviewed changes

Contributor Author

ibrahimrabab commented Sep 10, 2024

/check-enforcer override

ibrahimrabab merged commit 37d8cdc into Azure:main

31 of 35 checks passed

ibrahimrabab deleted the syncStack-blobs branch

September 10, 2024 17:55

ibrahimrabab added a commit that referenced this pull request


          Revert "Blobs Sync Stack Migration (#40812)"

2beb462

This reverts commit 37d8cdc.

ibrahimrabab mentioned this pull request

Revert "Blobs Sync Stack Migration" #41819

Merged

ibrahimrabab added a commit that referenced this pull request


          Revert "Blobs Sync Stack Migration (#40812)" (#41819)

ac9ee63

This reverts commit 37d8cdc.

mssfang pushed a commit that referenced this pull request


          Blobs Sync Stack Migration (#40812)

0f53e43

mssfang pushed a commit that referenced this pull request


          Revert "Blobs Sync Stack Migration (#40812)" (#41819)

c8279b3

This reverts commit 37d8cdc.

ibrahimrabab added a commit to ibrahimrabab/azure-sdk-for-java that referenced this pull request


          Reapply "Blobs Sync Stack Migration (Azure#40812)" (Azure#41819)

1aee530

This reverts commit ac9ee63.

jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request


          Blobs Sync Stack Migration (Azure#40812)

05de9eb

jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request


          Revert "Blobs Sync Stack Migration (Azure#40812)" (Azure#41819)

75bb441

This reverts commit 37d8cdc.

ibrahimrabab added a commit that referenced this pull request


          Reapply "Blobs Sync Stack Migration (#40812)" (#41819) (#41968)

5e1a8d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alzimmermsft alzimmermsft approved these changes

seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

ibrandes Awaiting requested review from ibrandes ibrandes is a code owner

srnagar Awaiting requested review from srnagar

kyleknap Awaiting requested review from kyleknap kyleknap is a code owner

Labels

Storage