-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change EventHubsTemplate to not use block() for async #40772
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution @AlanKrueger! We will review the pull request and get back to you soon. |
Converting to draft to give me time to ensure I'm on a solid footing for contribution w/r/t my employer. |
Hi @AlanKrueger. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @AlanKrueger. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
@AlanKrueger please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
API change check API changes are not detected in this pull request. |
Description
Issues #35845 and #35215 appear to be due to
EventHubsTemplate.doSend
performing ablock()
call. When used by the non-async methods inEventHubsTemplate
, or the async methods when a non-parallel ReactorScheduler
is being used, this will work well enough. But when using a parallel ReactorScheduler
, blocking calls are prohibited.This PR restructures the code in
EventHubsTemplate.doSend
to not use a blocking call. A test was added first to verify that we could detect this condition by performing one of the existing test cases withScheduler.parallel()
. After the changes toEventHubsTemplate
, this test passes.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines