-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAI-Assistant] Added vector store feature #40467
[OpenAI-Assistant] Added vector store feature #40467
Conversation
mssfang
commented
Jun 4, 2024
•
edited
Loading
edited
- Added support for vector store, vector store with file and a batch of files operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. Apologies again for the likely conflicts you might get while rebasing or merging the base branch.
Were you able to generate recordings for these tests? I don't see an update to the assets.json
file, so I suppose you either encountered an issue or you wanted to avoid possible conflicts (which I totally understand)
...s/src/main/java/com/azure/ai/openai/assistants/models/AssistantsApiResponseFormatOption.java
Outdated
Show resolved
Hide resolved
...ai-assistants/src/main/resources/META-INF/azure-ai-openai-assistants_apiview_properties.json
Show resolved
Hide resolved
...enai-assistants/src/test/java/com/azure/ai/openai/assistants/AzureVectorStoreAsyncTests.java
Outdated
Show resolved
Hide resolved
...enai-assistants/src/test/java/com/azure/ai/openai/assistants/AzureVectorStoreAsyncTests.java
Outdated
Show resolved
Hide resolved
...ai-openai-assistants/src/test/java/com/azure/ai/openai/assistants/VectorStoreAsyncTests.java
Outdated
Show resolved
Hide resolved
No worries. I am able to record the new tests' json file and works fine in playback mode now. |
914e017
into
Azure:jpalvarezl/issue_39769_assistants_v2_support
…ase (#40389) * Updated commit hash to latest assistantv2 commit * Using commit without the openAPI v3 annotations * Project compiles * Code regen after tooling update and commit cherry picking * Corrections to the readme from codegen * Code regen * Code regen * Modified return types for paginated endpoints * Migrated paged endpoints to use PageableList<> async * Added test skeleton class for vectorStore * Updated commit hash * WIP: introduced intermediate type for custom serialization logic * WIP: trying to add tests, running into issues * Removed AssistantFile related class * Fixed (de)serialization for assistantCreation response_format * Added docs for getters * Added customization for createRunOptions * Added tests for CreateAndRunThreadOptions * Added tests for updateAssistantOption * Added tests for getter methods * Added assertion for getters too * Removed some left over @generated * Code regen * Added missing responseFormat handling for ThreadRun * Added tests for tool_choice * Addd tests for createAndRunThreadOptions * Added tests createRunOptions * Removed imports * Added tests for null input JSON * code regen * Adjusted header value to use v2 for openAI * Updated test recordings * Removing recordings for removed tests * using a commit hash from main * Ajusted method * Re-recorded as much as possible. Adjusted some assertions. Marked tests that need more work * WIP: sanitizers behaivour * Renamed/removed retrieval related classes to file_search * WIP: deserialization is failing * Fle search test passing * Updated tests for file_search * Addressed 404 * renamed sample * Code regen * Various test improvements * WIP: style checks * Style checks * More style checks * [OpenAI-Assistant] Added vector store feature (#40467) * use the main repo's SHA * fixed the typo * Trying to make the CI happy * Second try * Reverting changes * WIP: sorting added features and breaking changes * Last details in the CHANGELOG * Typos and casing issues * CHANGELOG feedback * fixed the sanitizer CI failures * Added a few more notes in CHANGELOG.md --------- Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: Shawn Fang <shafang@microsoft.com>