[OpenAI-Assistant] Added vector store feature #40467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mssfang
commented
Jun 4, 2024
•
mssfang
commented
- Added support for vector store, vector store with file and a batch of files operations.
mssfang
added
Client
jpalvarezl
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
I think it looks good. Apologies again for the likely conflicts you might get while rebasing or merging the base branch.
Were you able to generate recordings for these tests? I don't see an update to the assets.json file, so I suppose you either encountered an issue or you wanted to avoid possible conflicts (which I totally understand)
...s/src/main/java/com/azure/ai/openai/assistants/models/AssistantsApiResponseFormatOption.java
Outdated
Show resolved
Hide resolved
...ai-assistants/src/main/resources/META-INF/azure-ai-openai-assistants_apiview_properties.json
Show resolved
Hide resolved
...enai-assistants/src/test/java/com/azure/ai/openai/assistants/AzureVectorStoreAsyncTests.java
Outdated
Show resolved
Hide resolved
...enai-assistants/src/test/java/com/azure/ai/openai/assistants/AzureVectorStoreAsyncTests.java
Outdated
Show resolved
Hide resolved
...ai-openai-assistants/src/test/java/com/azure/ai/openai/assistants/VectorStoreAsyncTests.java
Outdated
Show resolved
Hide resolved
No worries. I am able to record the new tests' json file and works fine in playback mode now. |
mssfang
merged commit 914e017
into
Azure:jpalvarezl/issue_39769_assistants_v2_support
3 of 4 checks passed
jpalvarezl
added a commit
that referenced
this pull request
Jun 6, 2024
…ase (#40389) * Updated commit hash to latest assistantv2 commit * Using commit without the openAPI v3 annotations * Project compiles * Code regen after tooling update and commit cherry picking * Corrections to the readme from codegen * Code regen * Code regen * Modified return types for paginated endpoints * Migrated paged endpoints to use PageableList<> async * Added test skeleton class for vectorStore * Updated commit hash * WIP: introduced intermediate type for custom serialization logic * WIP: trying to add tests, running into issues * Removed AssistantFile related class * Fixed (de)serialization for assistantCreation response_format * Added docs for getters * Added customization for createRunOptions * Added tests for CreateAndRunThreadOptions * Added tests for updateAssistantOption * Added tests for getter methods * Added assertion for getters too * Removed some left over @generated * Code regen * Added missing responseFormat handling for ThreadRun * Added tests for tool_choice * Addd tests for createAndRunThreadOptions * Added tests createRunOptions * Removed imports * Added tests for null input JSON * code regen * Adjusted header value to use v2 for openAI * Updated test recordings * Removing recordings for removed tests * using a commit hash from main * Ajusted method * Re-recorded as much as possible. Adjusted some assertions. Marked tests that need more work * WIP: sanitizers behaivour * Renamed/removed retrieval related classes to file_search * WIP: deserialization is failing * Fle search test passing * Updated tests for file_search * Addressed 404 * renamed sample * Code regen * Various test improvements * WIP: style checks * Style checks * More style checks * [OpenAI-Assistant] Added vector store feature (#40467) * use the main repo's SHA * fixed the typo * Trying to make the CI happy * Second try * Reverting changes * WIP: sorting added features and breaking changes * Last details in the CHANGELOG * Typos and casing issues * CHANGELOG feedback * fixed the sanitizer CI failures * Added a few more notes in CHANGELOG.md --------- Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: Shawn Fang <shafang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.