Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for Ability to create Container Registry with zone redundancy #38588

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fixed for Ability to create Container Registry with zone redundancy #38588

merged 2 commits into from
Feb 2, 2024

Conversation

v-hongli1
Copy link
Member

@v-hongli1 v-hongli1 commented Feb 2, 2024

relate to issue#38488

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-containerregistry

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Feb 2, 2024

  1. can it be disabled in update flow?
  2. should we return boolean (and name it isZoneRedundencyEnabled())?
  3. old question, enableZoneRedundency or withZoneRedundency :-)

@XiaofeiCao

@XiaofeiCao
Copy link
Contributor

isZoneRedundancyEnabled() should be more appropriate.

I'm fine with both enableZoneRedundancy and withZoneRedundancy. If we consider zone redundancy as an ability to have, withZoneRedundancy makes sense too.

@weidongxu-microsoft
Copy link
Member

can it be disabled in update flow?

@v-hongli1
Copy link
Member Author

v-hongli1 commented Feb 2, 2024

@weidongxu-microsoft

  1. I tried updating the initial settings of "ZoneRedundancy", but the backend doesn't support it. At the same time, similar updates are not supported on the portal.
  2. Now the Update flow uses updateParameters to save update items and values, but the member object or method associated with ZoneRedundancy cannot be found in updateParameters, so the update settings of ZoneRedundancy cannot be recorded in updateParameters.

@weidongxu-microsoft
Copy link
Member

OK. Then create flow is fine.

@v-hongli1 v-hongli1 merged commit 922d0bb into Azure:main Feb 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants