Skip to content

Add Vector Search Samples and Tests #35820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

Add Vector Search Samples and Tests #35820

merged 2 commits into from
Jul 11, 2023

Conversation

@alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Jul 11, 2023

Description

Adds samples and tests for Cognitive Search's Vector search.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Search Client This issue points to a problem in the data-plane of the library. labels Jul 11, 2023
@alzimmermsft alzimmermsft requested a review from mssfang as a code owner July 11, 2023 15:56
@alzimmermsft alzimmermsft self-assigned this Jul 11, 2023
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 11, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-search-documents

@alzimmermsft
Copy link
Member Author

alzimmermsft commented Jul 11, 2023

/azp run java - search - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 11, 2023

Azure Pipelines successfully started running 1 pipeline(s).

jairmyree
jairmyree approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jairmyree jairmyree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft enabled auto-merge (squash) July 11, 2023 17:25
@alzimmermsft alzimmermsft merged commit e6ed3b0 into Azure:main Jul 11, 2023
@alzimmermsft alzimmermsft deleted the AzSearch_VectorSearchTests branch July 11, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jairmyree jairmyree jairmyree approved these changes

@mssfang mssfang Awaiting requested review from mssfang

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels

Client This issue points to a problem in the data-plane of the library. Search

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alzimmermsft @azure-sdk @jairmyree