Update kv secrets sync stack #30136
Merged
Update kv secrets sync stack #30136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
g2vinay
commented
Jul 26, 2022
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Show resolved
Hide resolved
Contributor
kasobol-msft
left a comment
kasobol-msft
left a comment
There was a problem hiding this comment.
overall lgtm.
please add couple of tests that assert that right pipeline/httpclient apis are called.
...ty-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java
Outdated
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Outdated
Show resolved
Hide resolved
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
samvaity
reviewed
Jul 28, 2022
...ty-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java
Show resolved
Hide resolved
...ty-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretAsyncClient.java
Outdated
Show resolved
Hide resolved
...ecurity-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/SecretClient.java
Outdated
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Outdated
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Outdated
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Show resolved
Hide resolved
sdk/keyvault/azure-security-keyvault-secrets/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
kasobol-msft
approved these changes
Aug 2, 2022
samvaity
reviewed
Aug 2, 2022
| Configuration buildConfiguration = | ||
| (configuration == null) ? Configuration.getGlobalConfiguration().clone() : configuration; | ||
|
|
||
| URL buildEndpoint = getBuildEndpoint(buildConfiguration); |
Member
There was a problem hiding this comment.
Should we follow the same thing as KV keys here and return a String instead of an URL.
String buildEndpoint = getBuildEndpoint(buildConfiguration);
...crets/src/main/java/com/azure/security/keyvault/secrets/implementation/SecretClientImpl.java
Outdated
Show resolved
Hide resolved
…String to SecretServiceVersion.
…Updated POM to allow for this on tests runs for Java 9+.
vcolin7
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Sync Stack in KV Secrets SDK.
Note: Polling and List APIs will be Syncified later as support for them lands in Azure Core.
Enables Sync Rest Proxy by default for KV APIs.