Skip to content

Conversation

@samvaity
Copy link
Member

@samvaity samvaity commented Jul 19, 2022

This PR integrates Sync workflow for AppConfig client SDK.
The Sync clients for appconfig will no longer block on async client APIs but rather call their respective non-blocking synchronous APIs for fulfilling the request.

Follow-up PR to update Paging API's #30031

@ghost ghost added the App Configuration Azure.ApplicationModel.Configuration label Jul 19, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 19, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-data-appconfiguration
azure-data-appconfiguration
azure-core-test

@samvaity samvaity self-assigned this Jul 19, 2022
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List API's to be updated in a follow-up PR once #30031 is resolved.

Copy link
Contributor

@kasobol-msft kasobol-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, how are we doing with test converage?

@samvaity samvaity force-pushed the sync-stack-appConfig branch from 532bc3b to 2adde37 Compare July 20, 2022 02:37
@samvaity samvaity force-pushed the sync-stack-appConfig branch 3 times, most recently from b336fc8 to 98a06cc Compare July 25, 2022 18:32
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@samvaity samvaity force-pushed the sync-stack-appConfig branch from 49f31c5 to 96d2d0a Compare July 26, 2022 00:01
@samvaity samvaity marked this pull request as ready for review July 26, 2022 16:48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two suppression can be merged to a single one I believe.

@samvaity samvaity force-pushed the sync-stack-appConfig branch from fd101c8 to 942b4e7 Compare July 28, 2022 18:07
@samvaity samvaity changed the title Sync stack - AppConfig Integrate sync stack workflow for AppConfig Jul 28, 2022
@ghost
Copy link

ghost commented Jul 28, 2022

Hello @samvaity!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@samvaity samvaity force-pushed the sync-stack-appConfig branch from 1ce79ef to 499a8ae Compare July 29, 2022 20:41
@ghost ghost merged commit 0823942 into Azure:main Jul 29, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants