-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Integrate sync stack workflow for AppConfig #30028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-data-appconfiguration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List API's to be updated in a follow-up PR once #30031 is resolved.
kasobol-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, how are we doing with test converage?
...ation/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationService.java
Outdated
Show resolved
Hide resolved
...appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationAsyncClient.java
Outdated
Show resolved
Hide resolved
532bc3b to
2adde37
Compare
...ation/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationService.java
Outdated
Show resolved
Hide resolved
b336fc8 to
98a06cc
Compare
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
49f31c5 to
96d2d0a
Compare
eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
Outdated
Show resolved
Hide resolved
...appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationAsyncClient.java
Outdated
Show resolved
Hide resolved
...data-appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationClient.java
Outdated
Show resolved
Hide resolved
...main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientCredentials.java
Outdated
Show resolved
Hide resolved
...main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientCredentials.java
Outdated
Show resolved
Hide resolved
...main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientCredentials.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientImpl.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientImpl.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/src/main/java/com/azure/core/test/http/AssertingClient.java
Outdated
Show resolved
Hide resolved
...appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationAsyncClient.java
Outdated
Show resolved
Hide resolved
746c4d4 to
fd101c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two suppression can be merged to a single one I believe.
fd101c8 to
942b4e7
Compare
...appconfiguration/src/main/java/com/azure/data/appconfiguration/ConfigurationAsyncClient.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientImpl.java
Outdated
Show resolved
Hide resolved
...main/java/com/azure/data/appconfiguration/implementation/ConfigurationClientCredentials.java
Outdated
Show resolved
Hide resolved
|
Hello @samvaity! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
1ce79ef to
499a8ae
Compare
This PR integrates Sync workflow for AppConfig client SDK.
The Sync clients for appconfig will no longer block on async client APIs but rather call their respective non-blocking synchronous APIs for fulfilling the request.
Follow-up PR to update Paging API's #30031