Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: StorageInputStream read methods hide root cause exception when stream is faulted #28638

Merged
merged 1 commit into from
May 4, 2022

Conversation

MartinTunzer-TomTom
Copy link
Contributor

Description

The method checkStreamState() for faulty stream hides the wrapped error cause because only the error message is given to the new RuntimeException. It is then not possible to properly react on an reading error (a proper reaction is required e.g. in the case of BlobStorageException, BlobErrorCode.CONDITION_NOT_MET).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

The method checkStreamState() for faulty stream hides the error cause as only the error message is given to the new RuntimeException.
@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels May 4, 2022
@ghost
Copy link

ghost commented May 4, 2022

Thank you for your contribution MartinTunzer-TomTom! We will review the pull request and get back to you soon.

@alzimmermsft
Copy link
Member

Thank you for filing this change @MartinTunzer-TomTom, it's greatly appreciated and I'd imagine many other people will find it extremely useful as well!

@alzimmermsft alzimmermsft merged commit 783eaa5 into Azure:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants