Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated KeyVaultCredentialPolicy to extend BearerTokenAuthenticationPolicy in Key Vault clients. #24199

Merged
merged 20 commits into from
Sep 30, 2021

Commits on Sep 18, 2021

  1. Replaced all uses of KeyVaultCredentialPolicy with BearerTokenAuthent…

    …icationPolicy in Key Vault clients. Removed the KeyVaultCredentialPolicy and ScopeTokeCache classes from all Track 2 Key Vault libraries.
    vcolin7 committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    36c18da View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. We now pass the appropriate scope to BearerTokenAuthenticationPolicy …

    …creating a new instance in client builders, tests and samples.
    vcolin7 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    095fc64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eed5e56 View commit details
    Browse the repository at this point in the history
  3. Removed unused imports.

    vcolin7 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    1d55f52 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Configuration menu
    Copy the full SHA
    e936df1 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Reintroduced KeyVaultCredentialPolicy and modified it to extend from …

    …BearerTokenAuthenticationPolicy while extracting the scope provided in bearer challenges returned by the Key Vault service.
    vcolin7 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    911d295 View commit details
    Browse the repository at this point in the history
  2. Fixed CvheckStyle errors.

    vcolin7 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    a9a5a74 View commit details
    Browse the repository at this point in the history
  3. Made changes to KeyVaultCredentialPolicy so we don't set the body of …

    …a request as null, but an empty String instead.
    vcolin7 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    d63983d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ddc8659 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8947d6d View commit details
    Browse the repository at this point in the history
  6. Removed verify test for HSM as the FromSource test already verifies t…

    …he build's code coverage and running in parallel against the same HSM can cause problems for some tests.
    vcolin7 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    acecf59 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Reverted KeyVaultCredentialPolicy in all libraries to set the request…

    … body to null instead of an empty string when sending the first unauthenticated request to get a bearer challenge. Also stored the value of the "Content-Length" header in the pipeline context for use in a subsequent request.
    vcolin7 committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    c331b23 View commit details
    Browse the repository at this point in the history
  2. Fixed KV Administration client live tests that failed due to the auth…

    …entication policy changes. Also fixed some flaky live tests.
    vcolin7 committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    3038a19 View commit details
    Browse the repository at this point in the history
  3. Fixed CheckStyle issues.

    vcolin7 committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    be31274 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    16de813 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Fixed issue that caused an NPE in KeyVaultCredentialPolicy if the con…

    …tent of the request being originally sent were null from the beginning.
    vcolin7 committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    2ba9e74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b58aaf View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    674e4a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Configuration menu
    Copy the full SHA
    a7f5d98 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Applied PR feedback.

    vcolin7 committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    938c74c View commit details
    Browse the repository at this point in the history