Enable access token cache. #23847
Merged
Enable access token cache. #23847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
chenrujun
suggested changes
Sep 2, 2021
...vault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/model/OAuthToken.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/model/OAuthToken.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/model/OAuthToken.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/model/OAuthToken.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
...-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java
Outdated
Show resolved
Hide resolved
|
Hi, @michaelqi793 , if this PR is ready to ready for review, please click |
michaelqi793
requested review from
backwind1233,
moarychan,
saragluna,
stliu,
yiliuTo and
ZhuXiaoBing-cn
as code owners
michaelqi793
requested review from
g2vinay,
samvaity and
vcolin7
as code owners
added 7 commits
September 7, 2021 15:05
...eyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/KeyVaultClient.java
Outdated
Show resolved
Hide resolved
|
I haven't looked at the implementation yet, but here's the class we use from Azure Core that handles this type of authentication: BearerTokenAuthenticationPolicy. Hope it helps for something :P |
Thanks Vcolin! key vault jca should be light, it does not use this chain of responsibility currently. |
chenrujun
approved these changes
Sep 22, 2021
...eyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/KeyVaultClient.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23473