ValidateUri configured in CosmosProperties #23641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwind1233
requested review from
chenrujun,
michaelqi793,
moarychan,
saragluna,
stliu,
zhichengliu12581 and
ZhuXiaoBing-cn
as code owners
ghost
added
the
chenrujun
reviewed
Aug 18, 2021
| @@ -137,4 +144,10 @@ public ConnectionMode getConnectionMode() { | |||
| public void setConnectionMode(ConnectionMode connectionMode) { | |||
| this.connectionMode = connectionMode; | |||
| } | |||
|
|
|||
| private void validateUri() { | |||
| if (StringUtils.startsWithIgnoreCase(uri, "mongodb://")) { | |||
There was a problem hiding this comment.
How about using allow list instead of blocking list?
There was a problem hiding this comment.
which blocking list? I don't understand you.
There was a problem hiding this comment.
Your current implementation is blocking mongodb://.
There was a problem hiding this comment.
can you give me an example?😂
There was a problem hiding this comment.
private static final List<String> SUPPORTED_URI_PREFIX = Arrays.asList("foo", "bar", ...);
|
Hi @chenrujun, please help review this PR, I will handle the pipeline error.😀 |
chenrujun
approved these changes
Aug 23, 2021
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(CosmosProperties.class); | ||
|
|
||
| public static final String URIPATTERN = "http[s]{0,1}://.*.documents.azure.com.*"; |
3 tasks
|
Hi @kushagraThapar,could you please help reivew this PR, help check the uri pattern for cosmosdb? did I miss something? |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 20, 2023
mgmt, add "timeCreated" to "VirtualMachineScaleSetVMProperties" (Azure#23641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure-spring-data-cosmos does not support mongdb, if
azure.cosmos.uriconfigured with mongdb, thrown an exception.Reference
github repo: azure-spring-data-cosmos
Azure Cosmos DB Resource URI Syntax for REST