Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate IoT Hub control plane SDK to use new service API version #22815

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

timtay-microsoft
Copy link
Member

@timtay-microsoft timtay-microsoft commented Jul 7, 2021

Azure/azure-rest-api-specs#14894

Also adding a simple code generation script for local generation for other service API version increases later that we'll need to regenerate this SDK for

This new service API version is not deployed in every region yet, so this code is not ready to be released, but my team would like it checked in so the nightly built jars can be used for an upcoming bugbash.

@check-enforcer
Copy link

check-enforcer bot commented Jul 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

Azure/azure-rest-api-specs#14894

Also adding a simple code generation script for local generation for other service API version increases later that we'll need to regenerate this SDK for
--sdk-integration `
--fluent=lite `
--java.fluent=lite `
--java.license-header=MICROSOFT_MIT_SMALL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try with one additional option --generate-samples to allow codegen to generate some sample codes for you (from swagger).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@timtay-microsoft timtay-microsoft merged commit 2b11922 into main Jul 8, 2021
@timtay-microsoft timtay-microsoft deleted the timtay/iothubControlPlane branch July 8, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants