Make KeyVaultJcaProvider can work when keyvault-uri is not set. #22488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrujun
commented
Jun 24, 2021
chenrujun
commented
- Make KeyVaultJcaProvider can work when keyvault-uri is not set.
- Delete unused property: azure.keyvault.aad-authentication-url
- Reuse the code in test.
- Rename KeyVaultProperties to AzureKeyVaultProperties.
- Add AzureCertPathProperties.
2. Delete unused property: azure.keyvault.aad-authentication-url 3. Reuse the code in test. 4. Rename KeyVaultProperties to AzureKeyVaultProperties. 5. Add AzureCertPathProperties.
chenrujun
requested review from
backwind1233,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
|
Hi, @lzc-1997-abel . |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
|
LGTM |
stliu
reviewed
Jun 24, 2021
| * @see <a href="https://docs.spring.io/spring-boot/docs/current/reference/html/appendix-configuration-metadata.html">Metadata</a> | ||
| */ | ||
| @EnableConfigurationProperties({ AzureCertPathProperties.class }) | ||
| @ConfigurationProperties("azure.cert-path") |
There was a problem hiding this comment.
we should discuss this property name, azure.cert-path.custom seems not a clear name to me
There was a problem hiding this comment.
Current property name is the conclusion discussed with @gavinfish
Refs: #21611 (comment)
stliu
reviewed
Jun 24, 2021
| return; | ||
| } | ||
|
|
||
| putEnvironmentPropertyToSystemProperty(environment, "azure.keyvault.aad-authentication-url"); |
There was a problem hiding this comment.
I'd suggest to add a warning message in log to warn users still having this property configed
There was a problem hiding this comment.
Maybe it's not necessary, because:
- If customer use
azure-spring-boot-starter-keyvault-certificates,azure.keyvault.aad-authentication-urlnever exist inKeyVaultProperties.java, so customer never know this property exists.
- If customer use
azure-security-keyvault-jca, this already written in changelog:
stliu
reviewed
Jun 24, 2021
| @@ -27,11 +27,6 @@ | |||
| @Override | |||
| public void postProcessEnvironment(ConfigurableEnvironment environment, SpringApplication application) { | |||
|
|
|||
| if (environment.getProperty("azure.keyvault.uri") == null) { | |||
There was a problem hiding this comment.
is there any side effect with this remove?
chenrujun
deleted the
make-KeyVaultJcaProvider-can-work-when-keyvault-uri-is-not-set-for-starter-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.