-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme and changelog for jca #22283
Merged
chenrujun
merged 12 commits into
Azure:master
from
zhichengliu12581:add-support-fileSystem3
Jun 17, 2021
Merged
update readme and changelog for jca #22283
chenrujun
merged 12 commits into
Azure:master
from
zhichengliu12581:add-support-fileSystem3
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhichengliu12581
commented
Jun 15, 2021
•
edited
Loading
edited
- update readme and changelog for jca
- update function in Load cert from file system in key vault #21947 and optimize which with comment
ghost
added
the
KeyVault
label
Jun 15, 2021
zhichengliu12581
changed the title
Optimize https://github.com/Azure/azure-sdk-for-java/pull/21947 according to comment
Optimize keyvault according to comment
Jun 15, 2021
zhichengliu12581
requested review from
backwind1233,
chenrujun,
g2vinay,
samvaity,
saragluna,
stliu,
vcolin7 and
yiliuTo
as code owners
June 15, 2021 09:53
zhichengliu12581
changed the title
Optimize keyvault according to comment
update readme and changelog for jca
Jun 15, 2021
/azp run java - keyvault - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
suggested changes
Jun 16, 2021
...urity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/FileSystemCertificates.java
Outdated
Show resolved
Hide resolved
...urity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/FileSystemCertificates.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java
Outdated
Show resolved
Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java
Outdated
Show resolved
Hide resolved
...-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/test/PropertyConvertorUtils.java
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
chenrujun
suggested changes
Jun 16, 2021
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
chenrujun
suggested changes
Jun 16, 2021
...ity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/SpecificPathCertificates.java
Show resolved
Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java
Outdated
Show resolved
Hide resolved
...keyvault-jca/src/test/java/com/azure/security/keyvault/jca/SpecificPathCertificatesTest.java
Outdated
Show resolved
Hide resolved
...ity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/SpecificPathCertificates.java
Show resolved
Hide resolved
...ult-jca/src/test/java/com/azure/security/keyvault/jca/test/SpecificPathCertificatesTest.java
Outdated
Show resolved
Hide resolved
...ult-jca/src/test/java/com/azure/security/keyvault/jca/test/SpecificPathCertificatesTest.java
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
chenrujun
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.