Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme and changelog for jca #22283

Merged
merged 12 commits into from
Jun 17, 2021
Merged

update readme and changelog for jca #22283

merged 12 commits into from
Jun 17, 2021

Conversation

zhichengliu12581
Copy link
Contributor

@zhichengliu12581 zhichengliu12581 commented Jun 15, 2021 •
edited
Loading

  1. update readme and changelog for jca
  2. update function in Load cert from file system in key vault #21947 and optimize which with comment

@ghost ghost added the KeyVault label Jun 15, 2021
@zhichengliu12581 zhichengliu12581 changed the title Optimize https://github.com/Azure/azure-sdk-for-java/pull/21947 according to comment Optimize keyvault according to comment Jun 15, 2021
@zhichengliu12581 zhichengliu12581 marked this pull request as ready for review June 15, 2021 09:53
@zhichengliu12581 zhichengliu12581 changed the title Optimize keyvault according to comment update readme and changelog for jca Jun 15, 2021
@chenrujun
Copy link

/azp run java - keyvault - tests

@chenrujun chenrujun self-assigned this Jun 15, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun chenrujun added this to the [2021] July milestone Jun 15, 2021
chenrujun
chenrujun suggested changes Jun 16, 2021
View reviewed changes
...urity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/FileSystemCertificates.java Outdated Show resolved Hide resolved
...urity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/FileSystemCertificates.java Outdated Show resolved Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java Outdated Show resolved Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java Outdated Show resolved Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java Outdated Show resolved Hide resolved
...vault-jca/src/test/java/com/azure/security/keyvault/jca/test/FileSystemCertificatesTest.java Outdated Show resolved Hide resolved
...-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/test/PropertyConvertorUtils.java Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md Outdated Show resolved Hide resolved
chenrujun
chenrujun suggested changes Jun 16, 2021
View reviewed changes
...ity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/SpecificPathCertificates.java Show resolved Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java Outdated Show resolved Hide resolved
...keyvault-jca/src/test/java/com/azure/security/keyvault/jca/SpecificPathCertificatesTest.java Outdated Show resolved Hide resolved
...ity-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/SpecificPathCertificates.java Show resolved Hide resolved
...ult-jca/src/test/java/com/azure/security/keyvault/jca/test/SpecificPathCertificatesTest.java Outdated Show resolved Hide resolved
...ult-jca/src/test/java/com/azure/security/keyvault/jca/test/SpecificPathCertificatesTest.java Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md Outdated Show resolved Hide resolved
chenrujun
chenrujun approved these changes Jun 17, 2021
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun
Copy link

/check-enforcer override

@chenrujun chenrujun added the azure-spring All azure-spring related issues label Jun 17, 2021
@chenrujun chenrujun merged commit f4a0ced into Azure:master Jun 17, 2021
@zhichengliu12581 zhichengliu12581 deleted the add-support-fileSystem3 branch August 24, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@g2vinay g2vinay Awaiting requested review from g2vinay

@samvaity samvaity Awaiting requested review from samvaity

@saragluna saragluna Awaiting requested review from saragluna

@stliu stliu Awaiting requested review from stliu

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues KeyVault
Projects
None yet
Milestone
[2021] July
Development

Successfully merging this pull request may close these issues.
2 participants
@zhichengliu12581 @chenrujun