-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed and added Tables unit tests. #22196
Conversation
…ed classes to fit the XML shape the service expects.
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceAsyncClient.java
Outdated
Show resolved
Hide resolved
...ables/azure-data-tables/src/test/java/com/azure/data/tables/TableServiceAsyncClientTest.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
TableServiceAsyncClient secondaryClient = new TableServiceClientBuilder() | ||
.endpoint(secondaryEndpoint) | ||
.serviceVersion(serviceClient.getServiceVersion()) | ||
.pipeline(serviceClient.getHttpPipeline()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new pipeline is created if it's not provided in the builder. So, this isn't required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be better to use the same pipeline from the first client to use the same configuration. I think can write things better to make it so that we can get those settings in the test class itself.
* | ||
* @return This client's {@link HttpPipeline}. | ||
*/ | ||
HttpPipeline getHttpPipeline() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is not required.
…'operation' in samples and error messages.
...data-tables/src/main/java/com/azure/data/tables/implementation/models/TableServiceStats.java
Show resolved
Hide resolved
...es/azure-data-tables/src/samples/java/com/azure/data/tables/TransactionalBatchOperation.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
release 2023 02 01 (Azure#22474) * Adds base for updating Microsoft.SecurityInsights from version stable/2022-11-01 to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Provider sync properties (Azure#22198) * Alert Rules - add alert details override changes and PUT example (Azure#22196) * add alert details override changes and PUT example * add missing brace * add closing brace for alertDetailsOverride * add dynamic properties to 200 response * add dynamic details to 201 response --------- Co-authored-by: ShaniFelig <shfelifelig@microsoft.com> * Release Metadata 2023-02-01 stable version. (Azure#22161) * Release Metadata 2023-02-01 stable version. * Fix Swagger spec validation errors. * Revert Metadata service version to 2022-12-01-preview * Bring back changes for version 2023-02-01 * Fix model validation --------- Co-authored-by: Dor Siso <60354892+dosiso@users.noreply.github.com> Co-authored-by: ShaniFelig <74960756+ShaniFelig@users.noreply.github.com> Co-authored-by: ShaniFelig <shfelifelig@microsoft.com> Co-authored-by: Samuel Kuang <samuk@microsoft.com>
Also added recordings.
I had to modify some generated models to fit the XML shape the Storage service expects, for some reason the swagger was not enough for autorest to generate things properly. I will investigate further. It might come It may come down to some setting or adding transforms in the worst case.
Opened the following issue to track this: #22195.