Fixed and added Tables unit tests. #22196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed classes to fit the XML shape the service expects.
srnagar
reviewed
Jun 10, 2021
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableServiceAsyncClient.java
Outdated
Show resolved
Hide resolved
...ables/azure-data-tables/src/test/java/com/azure/data/tables/TableServiceAsyncClientTest.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Jun 10, 2021
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
| TableServiceAsyncClient secondaryClient = new TableServiceClientBuilder() | ||
| .endpoint(secondaryEndpoint) | ||
| .serviceVersion(serviceClient.getServiceVersion()) | ||
| .pipeline(serviceClient.getHttpPipeline()) |
There was a problem hiding this comment.
A new pipeline is created if it's not provided in the builder. So, this isn't required.
There was a problem hiding this comment.
I thought it would be better to use the same pipeline from the first client to use the same configuration. I think can write things better to make it so that we can get those settings in the test class itself.
| * | ||
| * @return This client's {@link HttpPipeline}. | ||
| */ | ||
| HttpPipeline getHttpPipeline() { |
…'operation' in samples and error messages.
...data-tables/src/main/java/com/azure/data/tables/implementation/models/TableServiceStats.java
Show resolved
Hide resolved
...es/azure-data-tables/src/samples/java/com/azure/data/tables/TransactionalBatchOperation.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/test/java/com/azure/data/tables/TableClientTest.java
Outdated
Show resolved
Hide resolved
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Feb 22, 2023
release 2023 02 01 (Azure#22474) * Adds base for updating Microsoft.SecurityInsights from version stable/2022-11-01 to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Provider sync properties (Azure#22198) * Alert Rules - add alert details override changes and PUT example (Azure#22196) * add alert details override changes and PUT example * add missing brace * add closing brace for alertDetailsOverride * add dynamic properties to 200 response * add dynamic details to 201 response --------- Co-authored-by: ShaniFelig <shfelifelig@microsoft.com> * Release Metadata 2023-02-01 stable version. (Azure#22161) * Release Metadata 2023-02-01 stable version. * Fix Swagger spec validation errors. * Revert Metadata service version to 2022-12-01-preview * Bring back changes for version 2023-02-01 * Fix model validation --------- Co-authored-by: Dor Siso <60354892+dosiso@users.noreply.github.com> Co-authored-by: ShaniFelig <74960756+ShaniFelig@users.noreply.github.com> Co-authored-by: ShaniFelig <shfelifelig@microsoft.com> Co-authored-by: Samuel Kuang <samuk@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added recordings.
I had to modify some generated models to fit the XML shape the Storage service expects, for some reason the swagger was not enough for autorest to generate things properly. I will investigate further. It might come It may come down to some setting or adding transforms in the worst case.
Opened the following issue to track this: #22195.