Add jre key store certificates to key vault key store, and add test for it. #21845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelqi793
requested review from
backwind1233,
chenrujun,
g2vinay,
samvaity,
saragluna,
stliu,
vcolin7 and
yiliuTo
as code owners
ghost
added
chenrujun
suggested changes
May 26, 2021
...ecurity-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/JreKeyStoreTest.java
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 26, 2021 17:30
|
Hi, @michaelqi793 , please fix the pipeline failure. |
chenrujun
suggested changes
May 27, 2021
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java
Show resolved
Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java
Outdated
Show resolved
Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java
Outdated
Show resolved
Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java
Outdated
Show resolved
Hide resolved
|
Hi, @michaelqi793 , please help to fix the pipeline failure. |
chenrujun
suggested changes
May 28, 2021
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Show resolved
Hide resolved
...ity-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultCertificatesTest.java
Outdated
Show resolved
Hide resolved
added 6 commits
May 28, 2021 11:38
chenrujun
suggested changes
May 31, 2021
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Outdated
Show resolved
Hide resolved
...ure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/JreCertificates.java
Show resolved
Hide resolved
...re-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultKeyStore.java
Show resolved
Hide resolved
|
Hi, @michaelqi793 , could you please update the changelog about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.