SDK version bump + Null context breaking change fix. #21655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azabbasi
requested review from
abhipsaMisra,
alzimmermsft,
barustum,
bikamani,
danieljurek,
drwill-ms,
g2vinay,
JimSuplizio,
JonathanGiles,
mitchdenny,
samvaity,
srnagar,
timtay-microsoft and
vinagesh
as code owners
ghost
added
the
azabbasi
commented
May 19, 2021
| @@ -586,6 +614,10 @@ public DigitalTwinsServiceVersion getServiceVersion() { | |||
| } | |||
|
|
|||
| Mono<Response<Void>> deleteRelationshipWithResponse(String digitalTwinId, String relationshipId, DeleteRelationshipOptions options, Context context) { | |||
| if (context == null) { | |||
There was a problem hiding this comment.
since these are package private methods, they can be called from elsewhere within the namespace so we do a null check and assign a default value to all of them.
drwill-ms
reviewed
May 19, 2021
drwill-ms
reviewed
May 19, 2021
drwill-ms
reviewed
May 19, 2021
...ure-digitaltwins-core/src/main/java/com/azure/digitaltwins/core/DigitalTwinsAsyncClient.java
Show resolved
Hide resolved
drwill-ms
reviewed
May 19, 2021
drwill-ms
approved these changes
May 19, 2021
srnagar
approved these changes
May 19, 2021
Comment on lines
+768
to
+769
| () -> listIncomingRelationshipsFirstPageAsync(digitalTwinId, context != null ? context : Context.NONE), | ||
| nextLink -> listIncomingRelationshipsNextSinglePageAsync(nextLink, context != null ? context : Context.NONE )); |
There was a problem hiding this comment.
nit: can do the check just once
if (context == null) {
context = Context.NONE;
}There was a problem hiding this comment.
I tried but the parameter in the lambda expression needs to be final :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.2in which a user could no longer pass downnullfor thecontextparameter in the synchronous APIs. We now use Context.NONE as the default value even if the user passes downnull