Configure cloud from keyvault uri #20530
Conversation
yiliuTo
requested review from
backwind1233,
chenrujun,
jialindai,
saragluna and
stliu
as code owners
ghost
added
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
…into support-cloud-configuration-jca
|
Hi, @yiliuTo . |
...ult/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/Constants.java
Outdated
Show resolved
Hide resolved
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultClient.java
Outdated
Show resolved
Hide resolved
| break; | ||
| default: | ||
| throw new IllegalArgumentException("Property of azure.keyvault.uri is illegal."); | ||
| } |
There was a problem hiding this comment.
- Write a method in
Constants:getAADLoginURIByKeyVaultBaseUri. - And rename
ConstantstoUriUtil. - Write unit test for the
getAADLoginURIByKeyVaultBaseUri.
There was a problem hiding this comment.
Done with point 1&2.
Do we still need a unit test for getAADLoginURIByKeyVaultBaseUri given it's just a switch statement? Does the current ut in KeyVaultClientTest meet the requirements?
...zure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/KeyVaultClient.java
Show resolved
Hide resolved
yiliuTo
changed the title
…into support-cloud-configuration-jca
...urity-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyManagerTest.java
Show resolved
Hide resolved
* identify and configure cloud environment from keyvault uri * add unit test to check url initialization * remove slash in base uri * refactor contructors * add changelog
To support keyvault jca in different Azure cloud environments, this pr configures keyvault resource uri and aad authentication automatically according to the property of azure.keyvault.uri provided by customers