fix reactor upgrade issue with bulk #20083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moderakh
requested review from
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
ealsur
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging master to feature branch brought reactor upgrade and we are constantly getting this error on bulk
EmitterProcessorthat we used in Spark for integrating against bulk is deprecated in the newer version of reactor and seems its behaviour has changed.replacing
EmitterProcessorwithSinks.many()seems to be the recommended path forward and solved the problem.There are also many deprecated apis of reactor-core which are used in bulk implementation in the core sdk. I suspect later we have to fix those as well.