Fix CI Failures #20065
Merged
Fix CI Failures #20065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
digimaun,
drwill-ms,
timtay-microsoft and
vinagesh
as code owners
…ckstyle, and tests missing playback records
|
@azabbasi mind taking a look |
alzimmermsft
commented
Mar 23, 2021
| @@ -190,7 +190,7 @@ public ModelsRepositoryAPIImplBuilder addPolicy(HttpPipelinePolicy customPolicy) | |||
| * @return an instance of ModelsRepositoryAPIImpl. | |||
| */ | |||
| public ModelsRepositoryAPIImpl buildClient() { | |||
| if(apiVersion == null){ | |||
| if (apiVersion == null) { | |||
There was a problem hiding this comment.
@srnagar is this an issue with codegen?
There was a problem hiding this comment.
@alzimmermsft are you referring to the formatting?
There was a problem hiding this comment.
Yeah, it was being flagged by Checkstyle linting
There was a problem hiding this comment.
yeah, I'll get this fixed in autorest.
alzimmermsft
commented
Mar 23, 2021
Comment on lines
+63
to
+66
| // TODO: These were disabled as they fail in Linux and macOS, likely due to '\' in the URI. | ||
| // Arguments.of("C:\\path\\to\\repository\\", | ||
| // "file:///C:/path/to/repository/dtmi/com/example/thermostat-1.json"), | ||
| // Arguments.of("\\\\server\\repository", "file:////server/repository/dtmi/com/example/thermostat-1.json") |
There was a problem hiding this comment.
@azabbasi these we disabled as they are failing in Linux and macOS, likely due to \ being in the URI
There was a problem hiding this comment.
I am working on fixing these in the PR I have open
you can merge this in if they are causing issues and cannot wait for the fix.
azabbasi
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mismatching version tags and missing README section.