Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] - SMS - Refactor SMS SDK and add *withResponse methods #19666

Merged
merged 6 commits into from
Mar 6, 2021
+813 −842
Merged

[Communication] - SMS - Refactor SMS SDK and add *withResponse methods #19666

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
189aace
Refactor SMS Clients and Tests
Mar 5, 2021
ba7ca0d
Updating readme and refactoring builder
Mar 5, 2021
367cd1e
Fix readme
Mar 5, 2021
0a8d5cc
Fix readme
Mar 5, 2021
3cc1209
Address review comments
Mar 5, 2021
4f7ce37
Address review comments
Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix readme
  • Loading branch information
Minnie Liu committed Mar 5, 2021
commit 0a8d5cce62cb72e502c541c8db221628b1d39de6
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-sms/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ SmsClient smsClient = new SmsClientBuilder()
```

### Access Key Authentication
Identity uses HMAC authentication with the resource access key.
SMS uses HMAC authentication with the resource access key.
The access key must be provided to the `SmsClientBuilder` via the credential() function. Endpoint and httpClient must also be set via the endpoint() and httpClient() functions respectively.

<!-- embedme src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java#L18-L29 -->
Expand Down