Skip to content

Fix #18217. add module-info.java to azure-security-keyvault-jca #19074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chenrujun wants to merge 3 commits into from
Closed

Fix #18217. add module-info.java to azure-security-keyvault-jca #19074

chenrujun wants to merge 3 commits into from

Conversation

@chenrujun
Copy link

@chenrujun chenrujun commented Feb 9, 2021

Fix #18217. add module-info.java to azure-security-keyvault-jca

@ghost ghost added KeyVault azure-spring All azure-spring related issues labels Feb 9, 2021
@chenrujun
Copy link
Author

chenrujun commented Feb 9, 2021

Hi, @saragluna :
Please help to review this PR. 🙏

@chenrujun chenrujun self-assigned this Mar 1, 2021
@chenrujun chenrujun marked this pull request as draft March 31, 2021 23:25
@chenrujun chenrujun mentioned this pull request Apr 21, 2021
Merged
@chenrujun chenrujun added this to the Backlog milestone Apr 28, 2021
@chenrujun
Copy link
Author

chenrujun commented May 18, 2021

Created a new PR: #21426
Closing this PR.

@chenrujun chenrujun closed this May 18, 2021
@chenrujun chenrujun deleted the add-module-info-in-azure-security-keyvault-jca branch May 18, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saragluna saragluna saragluna left review comments

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@jialindai jialindai Awaiting requested review from jialindai

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@chenrujun chenrujun

Labels

azure-spring All azure-spring related issues KeyVault

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Need to add module-info.java to azure-security-keyvault-jca

3 participants

@chenrujun @saragluna @rujche