Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a parameter to catalogs, Pipeline and Recurrence information, and object refactoring #1893

Merged
merged 16 commits into from
Sep 14, 2017

Conversation

ro-joowan
Copy link
Contributor

@ro-joowan ro-joowan commented Aug 28, 2017

  • Please note: This being my first Java PR, please bear with me as this has a quite a number of changes. I am still ramping up and will be keen on submitting changes in small batches quickly. Big thanks to Jianghao for helping me discover a bug and fixing it right away.

[PART 1: stuff I worked on with Ben Goldsmith] - commits from late July

  • Catalogs.java: added a parameter, called basic, to indicate that you want basic information rather than nested information about a table (i.e., list tables method) for performance increase

  • Adding Pipeline and Recurrence information to jobs

  • Added methods to get such information

  • Object refactoring and comment changes

[PART 2: code gen based on this PR: https://github.com/Azure/azure-rest-api-specs/pull/1429] - commits from Aug 27th

  • Code gen based on this PR: BREAKING CHANGE: Adl object refactor azure-rest-api-specs#1429

  • Modifying the gulpfile to align with the directory revamp of the Swagger repo

  • Modifying the test files to work with the object-refactoring changes in the PR

  • Adding a few more tests to align with the well-covered tests for .NET SDK

  • Removing "import com.microsoft.azure.SubResource"

…and object refactoring

* Catalogs.java: added a parameter, called basic, to indicate that you
want basic information rather than nested information about a table
(i.e., list tables method) for performance increase

* Adding Pipeline and Recurrence information to jobs
* Added methods to get such information

* Refactoring and comment changes
* Refactoring and comment changes
* Code gen based on this PR:
Azure/azure-rest-api-specs#1429

* Modifying the gulpfile to align with the directory revamp of the
Swagger repo

* Modifying the test files to work with the object-refactoring changes
in the PR

* Adding a few more tests to align with the well-covered tests for .NET
SDK

* Removing "import com.microsoft.azure.SubResource"
* For JobOperationsTests, I found a server side bug while testing this
call in the .NET SDK, so I was not surprised to see that it fails here
as well.

* For CatalogOperationsTests, I commented out "BUCKETS" from the script
because apparently that keyword is deprecated.  Furthermore, I commented
out the "canCreateUpdateDeleteSecretsAndCredentials" test because the
scripts that are being used are deprecated.  According to the error
message, I must use Azure Powershell cmdlets for such opeartions.  I am
not surprised at this because, to my knowledge, it's been a while since
this test case was run.  I will look into how I can test this in the
near future.

* Other than that, I made sure that JobOperationsTests as well as
AccountOperationsTests (for both ADLA and ADLS) passed.
@msftclas
Copy link

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ro-joowan
Copy link
Contributor Author

@jianghaolu Travis finally passes!!!

@jianghaolu jianghaolu merged commit d297b64 into Azure:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants