Normalize the package name for Doc.Ms readme #18856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
danieljurek,
JimSuplizio,
mitchdenny and
weshaggard
as code owners
weshaggard
reviewed
Feb 1, 2021
weshaggard
reviewed
Feb 1, 2021
| @@ -9,92 +9,8 @@ steps: | |||
| Write-Host "Target Dir: $targetDir" | |||
| msiexec /a ${{ parameters.EmulatorMsiUrl }} TARGETDIR=$targetDir /qn | wait-process | |||
| displayName: Download and Extract Public Cosmos DB Emulator | |||
| - powershell: | | |||
There was a problem hiding this comment.
Looks like you have some outdated changes.
There was a problem hiding this comment.
I am testing my changes with the tools change. Will revert the changes.
…into normalize_package_name
sima-zhu
force-pushed
the
normalize_package_name
branch
from
4931f8b
to
6b84db5
Compare
weshaggard
reviewed
Feb 2, 2021
sima-zhu
force-pushed
the
normalize_package_name
branch
from
6b84db5
to
e4319b2
Compare
weshaggard
approved these changes
Feb 2, 2021
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Feb 2, 2021
|
/check-enforcer override |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
May 11, 2022
Azure Event Grid 2021-12-01: Add missing isDataAction property from operation resource to address s360 LPI (Azure#18856) * Fix missing property * fix issecret Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=713510&view=logs&j=df6dbc9d-9cb6-55ac-00c8-bc457d14297a&t=44cfd120-b037-5184-ffdd-7a7fc47afe90
The readme we get from the workflow:
sdk-template-readme.mdwhich is the same as before.