Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement aad authn and authz #17325

Merged
merged 12 commits into from
Nov 11, 2020
Merged

implement aad authn and authz #17325

merged 12 commits into from
Nov 11, 2020

Conversation

jialindai
Copy link
Contributor

@jialindai jialindai commented Nov 9, 2020 •
edited by chenrujun
Loading

The PR contains the authentication and authorization support for AAD:

  • User authenticate and consent to all required permissions
  • User can get access token via @RegisteredOAuth2AuthorizedClient annotation

@ghost ghost added the azure-spring All azure-spring related issues label Nov 9, 2020
@jialindai jialindai added the azure-spring-aad Spring active directory related issues. label Nov 9, 2020
@check-enforcer
Copy link

check-enforcer bot commented Nov 9, 2020

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

chenrujun
chenrujun approved these changes Nov 10, 2020
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun chenrujun marked this pull request as ready for review November 11, 2020 05:08
@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo
yiliuTo approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun
Copy link

/check-enforcer override

@chenrujun chenrujun merged commit 69e4a5d into Azure:master Nov 11, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Feb 7, 2022
@ShaniFelig @roherzbe
@igalshapira @iKlotz @msklotz @royrein @lilyanc02 @viskumar-microsoft
CodeGen from PR 17494 in Azure/azure-rest-api-specs
0e10556 
Dev sentinel 2021 10 01 preview (Azure#17494)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-09-01-preview to version 2021-10-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add IoT data connector (Azure#17086)

* add Iot data connector

* fix kind in getIotById

* add deleted files

* add missing newlines

* fix newlines

* Revert "Add IoT data connector (Azure#17086)" (Azure#17170)

This reverts commit a11dd79ea1fb12c9b9d673fed2de91cc0098adbf.

* Adding providerIncidentUrl & techniques to IncidentAdditionalData (Azure#17173)

* Adding providerIncidentUrl to Incident

* Adding techniques to incident

* Dev sentinel 2021 10 01 preview (Azure#17314)

* Bookmarks 2021-10-01-preview

* prettier

* definitions

* rename

Co-authored-by: Igal Shapira <igshapir@microsoft.com>

* Data connectors 2021 10 01 preview office connectors added (Azure#17193)

* Project and PowerBI specs added.

* Space removed

* File with a wrong name removed

* More changer added

* Example files with inconsistent naming removed

* dataConnectors json updated

* Ref fixed

* Prettier applied

Co-authored-by: Ido Klotz <idoklotz@microsoft.com>

* AutomationRules preview 2021_10_01 (Azure#17325)

* h

* first

* examples

* prettier

* path

* fixes

* prettier

* examples

* Z

* Z

* responses

* fix

* fixes

* fix

* prettier

* PR Fixes

* PR Fixes

* PR Fixes

* fix

* fix

* fix

* fix

* Last

* PR Fixes

* Last

* tryFix

* tryFix

* incidentTypes

* fix

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Add MITRE support to alert rules models (Azure#17198)

* Update alert rules models with tactics and techniques

* Add attack tactics new enum values

* Update alert rules models examples

* Fix techniques type

* Update files with prettier

* Insert validations fixes

* Fix validations

* Fixes in alert rules models

* Fix alert rules models and examples

* adding changes to alert rules json

* Revert "adding changes to alert rules json"

This reverts commit 603490e300c76dee48550a11d0dee8fe5c824a2e.

* Adding fusion v2 ui api documentation

* some fixes

* adding prettier fixes

* removing unwanted property

* updating the readonly properties

Co-authored-by: Lilyan Cohen <licohen@microsoft.com>
Co-authored-by: Vishal Kumar <viskumar@microsoft.com>

* ErrorResponse changed to CloudError (Azure#17477)

Co-authored-by: Ido Klotz <idoklotz@microsoft.com>

* Done (Azure#17488)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Adding tenantId (Azure#17533)

Co-authored-by: Ido Klotz <idoklotz@microsoft.com>

* Done (Azure#17556)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* Fix LindDiff and SemanticValidation (Azure#17584)

Co-authored-by: ShaniFelig <74960756+ShaniFelig@users.noreply.github.com>
Co-authored-by: roherzbe <52486962+roherzbe@users.noreply.github.com>
Co-authored-by: Igal <igal.shapira@gmail.com>
Co-authored-by: Igal Shapira <igshapir@microsoft.com>
Co-authored-by: Ido Klotz <idoklotz@gmail.com>
Co-authored-by: Ido Klotz <idoklotz@microsoft.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: lilyanc02 <46589651+lilyanc02@users.noreply.github.com>
Co-authored-by: Lilyan Cohen <licohen@microsoft.com>
Co-authored-by: Vishal Kumar <viskumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrujun chenrujun chenrujun approved these changes

@yiliuTo yiliuTo yiliuTo approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@saragluna saragluna Awaiting requested review from saragluna

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jialindai @chenrujun @yiliuTo @rujche