Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escaping querying with IN clause #12720 #13327

Merged
merged 9 commits into from
Jul 22, 2020
Merged

escaping querying with IN clause #12720 #13327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
138c6cb
escaping querying with IN clause #12720
jacko9et Jul 20, 2020
84759c0
modify
jacko9et Jul 20, 2020
af025ed
modify
jacko9et Jul 20, 2020
2c94557
modify style
jacko9et Jul 21, 2020
5225463
Optimized code
jacko9et Jul 21, 2020
3429ad5
Optimized code
jacko9et Jul 21, 2020
48eb851
Optimized code
jacko9et Jul 22, 2020
c211a02
Optimized code
jacko9et Jul 22, 2020
b134ed9
Merge branch 'master' of github.com:Azure/azure-sdk-for-java into Fix…
jacko9et Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modify 
Signed-off-by: Jack Lu <dbqp99@msn.com>
  • Loading branch information
@jacko9et
jacko9et committed Jul 20, 2020
commit 84759c099333248aa2632f70e06cfca8ea5a32b0
6 changes: 3 additions & 3 deletions ...mos/src/main/java/com/azure/spring/data/cosmos/core/generator/AbstractQueryGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ private String generateInQuery(@NonNull Criteria criteria, @NonNull List<Pair<St
}

final Collection<Object> values = (Collection<Object>) criteria.getSubjectValues().get(0);

final StringBuilder builder = new StringBuilder();
int index = 0;
int index = 0;
Iterator<Object> iterator = values.iterator();
while (iterator.hasNext()) {
Object o = iterator.next();
Expand All @@ -148,7 +148,7 @@ private String generateInQuery(@NonNull Criteria criteria, @NonNull List<Pair<St
builder.append(",@").append(key);
}
parameters.add(Pair.with(key, o));
index ++;
index++;
} else {
throw new IllegalQueryException("IN keyword Range only support Number and String type.");
}
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/java/com/azure/spring/data/cosmos/repository/integration/ProjectRepositoryIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ public void testSqlInjection() {
assertProjectListEquals(projects, Arrays.asList(PROJECT_0, PROJECT_1, PROJECT_4));
projects = this.repository.findAllByHasReleasedIn(Collections.singleton(false));
assertProjectListEquals(projects, Arrays.asList(PROJECT_4));
projects = this.repository.findAllByNameIn(Collections.singleton("sql) or (r.firstName <> ''"));
projects = this.repository.findAllByNameIn(Collections.singleton("sql) or (r.name <> ''"));
assertTrue(projects.isEmpty());
}
}