Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity API updates July 2020 #13154

Merged
merged 12 commits into from
Jul 22, 2020
Merged

Identity API updates July 2020 #13154

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
07b26a9
Identity API updates July 2020
Jul 15, 2020
4a6da7e
update identity versions
Jul 15, 2020
faa0fec
update docs
Jul 15, 2020
d165178
Merge remote-tracking branch 'upstream/master' into identity-api-chan…
Jul 16, 2020
6f9b8aa
Merge branch 'master' into identity-api-changes-july2020
g2vinay Jul 17, 2020
9379033
Merge remote-tracking branch 'upstream/master' into identity-api-chan…
Jul 21, 2020
95e2a40
Merge branch 'identity-api-changes-july2020' of ssh://github.com/g2vi…
Jul 21, 2020
aa15c32
update API after consistency review
Jul 22, 2020
c18e062
update code
Jul 22, 2020
e0fa3d7
update docs
Jul 22, 2020
1a09bec
update code
Jul 22, 2020
5a8562b
fix checkstyle
Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update identity versions
  • Loading branch information
g2vinay committed Jul 15, 2020
commit 4a6da7e21afa81d1e4d9535512940d695fe6fa40
2 changes: 1 addition & 1 deletion ...ty/azure-identity/src/main/java/com/azure/identity/SharedTokenCacheCredentialBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ public SharedTokenCacheCredentialBuilder allowUnencryptedCache() {
*/
public SharedTokenCacheCredential build() {
return new SharedTokenCacheCredential(username, clientId, tenantId,
identityClientOptions.enablePersistentCache(true));
identityClientOptions.enablePersistentCache());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the SharedTokenCacheCredential to also take an AuthenticationRecord. See Azure/azure-sdk-for-net#13612. If you'd like we can merge this first and add this in a second PR, but we need to add it before the release.

}
}