Skip to content

[BUG] pom_file_version_scanner.ps1 needs better errors around misformed lines #39801

Open

Description

I mistakenly had a colon instead of a semicolon in a line in version_client.txt:

150:com.azure:azure-messaging-eventgrid;4.22.0;4.23.0-beta.1
151:com.azure:azure-messaging-eventgrid-namespaces:1.0.0-beta.1;1.0.0-beta.1
152:com.azure:azure-messaging-eventgrid-cloudnative-cloudevents;1.0.0-beta.1;1.0.0-beta.2

The resulting error confused me, because the line was obviously in the file:

➜ .\eng\versioning\pom_file_version_scanner.ps1
Using module powershell-yaml with version 0.4.7.
processing pomFile=D:\source\azure-sdk-for-java\sdk\eventgrid\azure-messaging-eventgrid-namespaces\pom.xml
Error: com.azure:azure-messaging-eventgrid-namespaces's dependency type is 'current' but the dependency does not exist in any of the version_*.txt files. Should this be an external_dependency? Please ensure the dependency type is correct or the dependency is added to the appropriate file.
There were errors encountered during execution. Please fix errors and run the script again.
This script can be run locally from the root of the repo. .\eng\versioning\pom_file_version_scanner.ps1

Ideally this would tell me I had a malformed line (missing a section) instead of telling me this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

EngSysThis issue is impacting the engineering system.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions