Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azcore separate tracer #23715

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Azcore separate tracer #23715

wants to merge 4 commits into from

Conversation

kjg
Copy link
Contributor

@kjg kjg commented Nov 8, 2024

  • Fixes [Tracing] Allow Client libraries to configure schema URL #23307

  • This PR allows a schemaURL to be passed to the NewTracer function so that consumers can create tracers that use a different schemaURL than azcore.

  • It updates azcore to use the otel semconv package that sets a schemaURL and then uses the semconv Constances for the span keys that have defined semconv keys.

This PR also adds a WithCoreTracerName function to the azcore client so the consumers that do want to do custom tracing can make azcore using azcore's module name and version for the HTTP tracing, and their own module name and version for their portion of the tracing. Using WithCoreTracerName only changes the values used for tracing to azcore values, it still leaves the passed in module name and version for use with the HTTP User Agent header.

I chose this approach because it looks like many of the consumers of this client

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

to allow azcore consumers to indicate the azcore tracer should
be named after the azcore module instead of the consumer's module
@github-actions github-actions bot added Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Thank you for your contribution @kjg! We will review the pull request and get back to you soon.

@kjg
Copy link
Contributor Author

kjg commented Nov 8, 2024

I'm not sure how to make the dependency check pass since I can't update tracing/azotel version of azcore and account for the breaking change until the change is merged and a new version released. Any guidance on how to approach that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracing] Allow Client libraries to configure schema URL
1 participant