Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support configuring azure cloud with env #23598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support configuring azure cloud with env #23598

wants to merge 1 commit into from
+35 −1

Conversation

or-shachar
Copy link

  • This adds support for AZURE_CLOUD env.
  • I followed terraform environment.
  • I wasn't quite sure how to test it.
  • I'm also not sure what to put in CHANGELOG.md

Checklist

@github-actions github-actions bot added Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 17, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @or-shachar! We will review the pull request and get back to you soon.

@or-shachar
Copy link
Author

@microsoft-github-policy-service agree

@or-shachar
feat: support configuring azure cloud with env
931c908 
Signed-off-by: Or Shachar <or.shachar@wiz.io>
@or-shachar or-shachar marked this pull request as ready for review October 21, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
Azure Identity SDK Improvements
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@or-shachar