Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage STG94 features #23367

Merged
merged 13 commits into from
Aug 26, 2024
Prev Previous commit
Next Next commit
Added AuthenticationErrorDetail (#23310)
* Added AuthenticationErrorDetail test

* error check

* corrected file error code
  • Loading branch information
tanyasethi-msft authored Aug 13, 2024
commit 442f0f131f2f823ba58385eed4f6b8579aed84cd
2 changes: 1 addition & 1 deletion sdk/storage/azfile/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "go",
"TagPrefix": "go/storage/azfile",
"Tag": "go/storage/azfile_23ee391082"
"Tag": "go/storage/azfile_d9960ee457"
}
55 changes: 55 additions & 0 deletions sdk/storage/azfile/share/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ package share_test
import (
"context"
"fmt"
"github.com/Azure/azure-sdk-for-go/sdk/azcore"
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
"github.com/Azure/azure-sdk-for-go/sdk/storage/azfile/fileerror"
Expand Down Expand Up @@ -278,6 +279,60 @@ func (s *ShareRecordedTestsSuite) TestShareCreateNilMetadata() {
_require.Len(response.Metadata, 0)
}

func (s *ShareRecordedTestsSuite) TestAuthenticationErrorDetailError() {
_require := require.New(s.T())
testName := s.T().Name()

cred, err := testcommon.GetGenericSharedKeyCredential(testcommon.TestAccountDefault)
_require.NoError(err)

svcClient, err := testcommon.GetServiceClient(s.T(), testcommon.TestAccountDefault, nil)
_require.NoError(err)

shareName := testcommon.GenerateShareName(testName)
shareClient := testcommon.CreateNewShare(context.Background(), _require, shareName, svcClient)
defer testcommon.DeleteShare(context.Background(), _require, shareClient)

id := "testAccessPolicy"
ps := share.AccessPolicyPermission{
Write: true,
}
_require.NoError(err)

signedIdentifiers := make([]*share.SignedIdentifier, 0)
signedIdentifiers = append(signedIdentifiers, &share.SignedIdentifier{
AccessPolicy: &share.AccessPolicy{
Expiry: to.Ptr(time.Now().Add(-1 * time.Hour)),
Permission: to.Ptr(ps.String()),
},
ID: &id,
})
_, err = shareClient.SetAccessPolicy(context.Background(), &share.SetAccessPolicyOptions{
ShareACL: signedIdentifiers,
})
_require.NoError(err)

sasQueryParams, err := sas.SignatureValues{
Protocol: sas.ProtocolHTTPS,
Identifier: id,
ShareName: shareName,
}.SignWithSharedKey(cred)
_require.NoError(err)

shareSAS := shareClient.URL() + "?" + sasQueryParams.Encode()
shareClientSAS, err := share.NewClientWithNoCredential(shareSAS, nil)
_require.NoError(err)

dirClient := testcommon.GetDirectoryClient(testcommon.GenerateDirectoryName(testName), shareClientSAS)
_, err = dirClient.Create(context.Background(), nil)
_require.Error(err)

var responseErr *azcore.ResponseError
_require.ErrorAs(err, &responseErr)
testcommon.ValidateFileErrorCode(_require, err, fileerror.AuthenticationFailed)
_require.Contains(responseErr.Error(), "AuthenticationErrorDetail")
}

func (s *ShareRecordedTestsSuite) TestShareCreateNegativeInvalidName() {
_require := require.New(s.T())
svcClient, err := testcommon.GetServiceClient(s.T(), testcommon.TestAccountDefault, nil)
Expand Down