Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azcontainerregistry: delegate token caching #23272

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

azcontainerregistry: delegate token caching #23272

wants to merge 3 commits into from

Commits on Aug 6, 2024

  1. azcontainerregistry: decouple token exchange from request specifics 

    I would like to propose a generally-useful token cache in a future
commit. Managing the refresh tokens and exchanging them for access
tokens does not need to rely specifically on the authentication policy
or the specific client request being made, so this commit decouples the
two concerns, thereby enabling the future refactor to be simpler.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
    @stevekuznetsov
    stevekuznetsov committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    67a0e05 View commit details
    Browse the repository at this point in the history

  2. azcontainerregistry: delegate token caching 

    Mechanically refactor token caching, retrieval and exchange behavior
from the authentication policy into a dedicated object, allowing us to
separate token management concerns from Azure client policy concerns.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
    @stevekuznetsov
    stevekuznetsov committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3206f97 View commit details
    Browse the repository at this point in the history

  3. azcontainerregistry: move code 

    This commit simply moves code from one location to another, broken out
from other commits for ease of review.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
    @stevekuznetsov
    stevekuznetsov committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    308795f View commit details
    Browse the repository at this point in the history