Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azmetrics] rename MetricValues to MetricData #22738

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[azmetrics] rename MetricValues to MetricData #22738

merged 2 commits into from
Apr 12, 2024

Conversation

gracewilcox
Copy link
Member

Cleaning up names. Changing MetricsValues to MetricData to avoid confusion with the existing MetricValue struct.

@gracewilcox gracewilcox added Monitor Monitor, Monitor Ingestion, Monitor Query Client This issue points to a problem in the data-plane of the library. labels Apr 11, 2024
@gracewilcox gracewilcox marked this pull request as ready for review April 11, 2024 23:58
@gracewilcox gracewilcox merged commit 3b88167 into Azure:main Apr 12, 2024
34 checks passed
@gracewilcox gracewilcox deleted the renames-azmetrics branch April 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@KevinBlasko KevinBlasko Awaiting requested review from KevinBlasko KevinBlasko is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@ToddKingMSFT ToddKingMSFT Awaiting requested review from ToddKingMSFT ToddKingMSFT is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

@gulopesd gulopesd Awaiting requested review from gulopesd gulopesd is a code owner automatically assigned from Azure/azure-sdk-write-monitor-data-plane

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gracewilcox @jhendrixMSFT