Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] add preferred regions logging #22598

Merged
merged 15 commits into from
Mar 19, 2024

Conversation

simorenoh
Copy link
Member

@simorenoh simorenoh commented Mar 15, 2024

Adds the missing client config logs since this flag was the last bit missing for that. Logs look like this:
image

Progress towards closing #18986.

@simorenoh simorenoh changed the title [Cosmos] add new client option DisableCrossRegionalRetries [Cosmos] add client settings logging Mar 15, 2024
@simorenoh simorenoh requested a review from ealsur March 15, 2024 21:41
@simorenoh
Copy link
Member Author

/azp run go - azcosmos - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh simorenoh changed the title [Cosmos] add client settings logging [Cosmos] add preferred regions logging Mar 15, 2024
@jhendrixMSFT
Copy link
Member

@benbp I think the ExcludeGoNMinus2 flag has regressed with the recent pipeline changes. It's set for azcosmos but is now showing up in CI.

@simorenoh
Copy link
Member Author

simorenoh commented Mar 18, 2024

@benbp - for context

with 1.21 in the go.mod file, these two runs complain of the lack of the min method:
image
image

with 1.22.0, the same two runs complain about the formatting:
image
image

It's only these two runs having issues - and previous PRs have already merged with the go.mod on 1.22.0:
#22394

sdk/data/azcosmos/ci.yml Outdated Show resolved Hide resolved
@simorenoh simorenoh merged commit b59b15c into Azure:main Mar 19, 2024
13 checks passed
@simorenoh simorenoh deleted the new-public-client-option-cosmos branch March 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants