API View for azfile #19873
Merged
API View for azfile #19873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-sdk-for-go into sourav/serviceClient
ghost
added
the
souravgupta-msft
requested review from
siminsavani-msft,
tasherif-msft and
jhendrixMSFT
as code owners
|
The CI failure is due to missing constant for the semantic version (it's not immediately clear from the error message). |
souravgupta-msft
requested review from
weshaggard,
ArcturusZhang,
lirenhe,
tadelesh,
gracewilcox,
chlowell,
richardpark-msft,
ealsur,
kirankumarkolli,
antkmsft and
RickWinter
as code owners
…or-go into sourav/serviceClient
souravgupta-msft
removed request for
benbp,
RickWinter,
weshaggard and
ArcturusZhang
souravgupta-msft
removed request for
lirenhe,
tadelesh,
gracewilcox,
chlowell,
richardpark-msft,
ealsur,
kirankumarkolli and
antkmsft
| // NewClientFromConnectionString creates an instance of Client with the specified values. | ||
| // - connectionString - a connection string for the desired storage account | ||
| // - shareName - the name of the share within the storage account | ||
| // - directoryName - the name of the directory within the storage account |
There was a problem hiding this comment.
Is directoryName here a sub-directory? So should the comment be more like "the name of the directory within the share"?
There was a problem hiding this comment.
(and a follow-on, if my previous comment is correct - what's the syntax if a user wants to specify a sub-folder with an additional sub-folder? Can they use backslashes or forward slashes?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azfile - API View