Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azcore] Remove logger from azcore #15160

Merged
merged 16 commits into from
Jul 29, 2021
Merged

[azcore] Remove logger from azcore #15160

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0920815
initial work, issues with using internal package
seankane-msft Jul 27, 2021
2f50adf
fixing up errors in logger file
seankane-msft Jul 27, 2021
e493952
adding logger test file
seankane-msft Jul 27, 2021
cfd0b67
removed an example
seankane-msft Jul 27, 2021
411066e
merge conflicts
seankane-msft Jul 28, 2021
a0a0446
feedback and removing circular dependency
seankane-msft Jul 28, 2021
b168cad
moving logclassification to be in logger, type alias in azcore
seankane-msft Jul 28, 2021
04e8eb6
merge
seankane-msft Jul 28, 2021
12f15a1
update internal version
seankane-msft Jul 28, 2021
597c047
fixes in azcore
seankane-msft Jul 28, 2021
eb5517e
fixes to azcore, works now
seankane-msft Jul 28, 2021
d776560
linter false positive
seankane-msft Jul 28, 2021
7edca67
catalina's comments
seankane-msft Jul 28, 2021
edc132a
more feedback
seankane-msft Jul 28, 2021
138f0fa
update version
seankane-msft Jul 29, 2021
c4059cc
Update sdk/azcore/version.go
seankane-msft Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more feedback
  • Loading branch information
@seankane-msft
seankane-msft committed Jul 28, 2021
commit edc132a23ce5bfe9a256fbd38e7656f26c676710
4 changes: 2 additions & 2 deletions sdk/azcore/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import (
"github.com/Azure/azure-sdk-for-go/sdk/internal/logger"
)

// SetClassifications is used to control which classifications are written to
// the log. By default all log classifications are writen.
// LogClassification is used to group entries. Each group can be toggled on or off
type LogClassification logger.LogClassification
seankane-msft marked this conversation as resolved.
Show resolved Hide resolved

const (
Expand Down Expand Up @@ -53,6 +52,7 @@ func transform(lst Listener) logger.Listener {
}
}

// SetListener will set the Logger to write to the specified Listener.
func SetListener(lst Listener) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing doc comment

if lst == nil {
logger.Log().SetListener(nil)
Expand Down