Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track2 autorest generated servicebus #15144

Closed
wants to merge 2 commits into from
Closed

track2 autorest generated servicebus #15144

wants to merge 2 commits into from

Conversation

Alancere
Copy link
Member

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Service Bus label Jul 26, 2021
ArcturusZhang
ArcturusZhang requested changes Jul 26, 2021
View reviewed changes
sdk/servicebus/armservicebus/_meta.json Outdated
"tag": "package-2018-01-preview",
"use": "@autorest/go@4.0.0-preview.24",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"autorest_command": "autorest --use=@autorest/go@4.0.0-preview.24 --version:3.3.2 --go --track2 --go-sdk-folder=/_/azure-sdk-for-go --file-prefix=\"zz_generated_\" --clear-output-folder=false /_/azure-rest-api-specs/specification/servicebus/resource-manager/readme.md",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have the option version in the autorest command any more

Suggested change
"autorest_command": "autorest --use=@autorest/go@4.0.0-preview.24 --version:3.3.2 --go --track2 --go-sdk-folder=/_/azure-sdk-for-go --file-prefix=\"zz_generated_\" --clear-output-folder=false /_/azure-rest-api-specs/specification/servicebus/resource-manager/readme.md",
"autorest_command": "autorest --use=@autorest/go@4.0.0-preview.24 --go --track2 --go-sdk-folder=/_/azure-sdk-for-go --file-prefix=\"zz_generated_\" --clear-output-folder=false /_/azure-rest-api-specs/specification/servicebus/resource-manager/readme.md",

sdk/servicebus/armservicebus/zz_generated_constants.go Outdated

package armservicebus

const telemetryInfo = "azsdk-go-armservicebus/<version>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After every generation we need to manually change the version number here

Suggested change
const telemetryInfo = "azsdk-go-armservicebus/<version>"
const telemetryInfo = "azsdk-go-armservicebus/v0.1.0"

sdk/servicebus/armservicebus/README.md Outdated
@@ -0,0 +1,76 @@
# Azure Container Registry Module for Go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the module name correspondingly

Suggested change
# Azure Container Registry Module for Go
# Azure Service Bus Module for Go

sdk/servicebus/armservicebus/README.md Outdated

[![PkgGoDev](https://pkg.go.dev/badge/github.com/Azure/azure-sdk-for-go/sdk/servicebus/armservicebus)](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/servicebus/armservicebus)

The `armservicebus` module provides operations for working with Azure Container Registry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `armservicebus` module provides operations for working with Azure Container Registry.
The `armservicebus` module provides operations for working with Azure Service Bus.

sdk/servicebus/armservicebus/README.md Outdated

This project uses [Go modules](https://github.com/golang/go/wiki/Modules) for versioning and dependency management.

Install the Azure Container Registry module:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Install the Azure Container Registry module:
Install the Azure Service Bus module:

sdk/servicebus/armservicebus/README.md Outdated

## Authorization

When creating a client, you will need to provide a credential for authenticating with Azure Container Registry. The `azidentity` module provides facilities for various ways of authenticating with Azure including client/secret, certificate, managed identity, and more.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When creating a client, you will need to provide a credential for authenticating with Azure Container Registry. The `azidentity` module provides facilities for various ways of authenticating with Azure including client/secret, certificate, managed identity, and more.
When creating a client, you will need to provide a credential for authenticating with Azure Service Bus. The `azidentity` module provides facilities for various ways of authenticating with Azure including client/secret, certificate, managed identity, and more.

sdk/servicebus/armservicebus/README.md Outdated

For more information on authentication, please see the documentation for `azidentity` at [pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity).

## Connecting to Azure servicebus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Connecting to Azure servicebus
## Connecting to Azure Service Bus

sdk/servicebus/armservicebus/README.md Outdated

## Clients

Azure Container Registry modules consist of one or more clients. A client groups a set of related APIs, providing access to its functionality within the specified subscription. Create one or more clients to access the APIs you require using your `armcore.Connection`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Azure Container Registry modules consist of one or more clients. A client groups a set of related APIs, providing access to its functionality within the specified subscription. Create one or more clients to access the APIs you require using your `armcore.Connection`.
Azure Service Bus modules consist of one or more clients. A client groups a set of related APIs, providing access to its functionality within the specified subscription. Create one or more clients to access the APIs you require using your `armcore.Connection`.

sdk/servicebus/armservicebus/README.md Outdated
Azure Container Registry modules consist of one or more clients. A client groups a set of related APIs, providing access to its functionality within the specified subscription. Create one or more clients to access the APIs you require using your `armcore.Connection`.

```go
client := armservicebus.NewRegistriesClient(con, "<subscription ID>")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm we have a function NewRegistriesClient in this package. If not, please randomly choose one NewXXXClient function in this module and put it here.

sdk/servicebus/armservicebus/README.md Outdated
## Provide Feedback

If you encounter bugs or have suggestions, please
[open an issue](https://github.com/Azure/azure-sdk-for-go/issues) and assign the `servicebus` label.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[open an issue](https://github.com/Azure/azure-sdk-for-go/issues) and assign the `servicebus` label.
[open an issue](https://github.com/Azure/azure-sdk-for-go/issues) and assign the `Service Bus` label.

@check-enforcer
Copy link

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

  • /check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
  • /check-enforcer override; by-pass Check Enforcer (approvals still required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang requested changes

@chamons chamons Awaiting requested review from chamons

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@seankane-msft seankane-msft Awaiting requested review from seankane-msft

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alancere @ArcturusZhang