consolidate status constants

sdk/armcore/internal/pollers/async/async.go

@@ -65,7 +65,7 @@ func New(resp *azcore.Response, finalState string, pollerID string) (*Poller, er
 			return nil, err
 		}*/
 		// for DELETE/PATCH/POST, provisioning state is optional
-		state = "InProgress"
+		state = pollers.StatusInProgress
 	} else if err != nil {
 		return nil, err
 	}

sdk/armcore/internal/pollers/body/body.go

@@ -13,11 +13,6 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
 )
 
-const (
-	stateSucceeded  = "Succeeded"
-	stateInProgress = "InProgress"
-)
-
 // Applicable returns true if the LRO is using no headers, just provisioning state.
 // This is only applicable to PATCH and PUT methods and assumes no polling headers.
 func Applicable(resp *azcore.Response) bool {
@@ -42,7 +37,7 @@ func New(resp *azcore.Response, pollerID string) (*Poller, error) {
 	}
 	// default initial state to InProgress.  depending on the HTTP
 	// status code and provisioning state, we might change the value.
-	curState := stateInProgress
+	curState := pollers.StatusInProgress
 	provState, err := pollers.GetProvisioningState(resp)
 	if err != nil && !errors.Is(err, pollers.ErrNoBody) && !errors.Is(err, pollers.ErrNoProvisioningState) {
 		return nil, err
@@ -55,10 +50,10 @@ func New(resp *azcore.Response, pollerID string) (*Poller, error) {
 			curState = provState
 		} else if provState == "" {
 			// for a 200, absense of provisioning state indicates success
-			curState = stateSucceeded
+			curState = pollers.StatusSucceeded
 		}
 	} else if resp.StatusCode == http.StatusNoContent {
-		curState = stateSucceeded
+		curState = pollers.StatusSucceeded
 	}
 	p.CurState = curState
 	return p, nil
@@ -77,7 +72,7 @@ func (p *Poller) Done() bool {
 // Update updates the Poller from the polling response.
 func (p *Poller) Update(resp *azcore.Response) error {
 	if resp.StatusCode == http.StatusNoContent {
-		p.CurState = stateSucceeded
+		p.CurState = pollers.StatusSucceeded
 		return nil
 	}
 	state, err := pollers.GetProvisioningState(resp)
@@ -86,7 +81,7 @@ func (p *Poller) Update(resp *azcore.Response) error {
 		return err
 	} else if errors.Is(err, pollers.ErrNoProvisioningState) {
 		// a response body without provisioning state is considered terminal success
-		state = stateSucceeded
+		state = pollers.StatusSucceeded
 	} else if err != nil {
 		return err
 	}

sdk/armcore/internal/pollers/loc/loc.go

@@ -36,7 +36,7 @@ func New(resp *azcore.Response, pollerID string) (*Poller, error) {
 	p := &Poller{
 		Type:     pollers.MakeID(pollerID, "loc"),
 		PollURL:  locURL,
-		CurState: "InProgress",
+		CurState: pollers.StatusInProgress,
 	}
 	return p, nil
 }
@@ -67,12 +67,12 @@ func (p *Poller) Update(resp *azcore.Response) error {
 			p.CurState = state
 		} else {
 			// a 200/201 with no provisioning state indicates success
-			p.CurState = "Succeeded"
+			p.CurState = pollers.StatusSucceeded
 		}
 	} else if resp.StatusCode == http.StatusNoContent {
-		p.CurState = "Succeeded"
+		p.CurState = pollers.StatusSucceeded
 	} else if resp.StatusCode > 399 && resp.StatusCode < 500 {
-		p.CurState = "Failed"
+		p.CurState = pollers.StatusFailed
 	}
 	// a 202 falls through, means the LRO is still in progress and we don't check for provisioning state
 	return nil

sdk/armcore/internal/pollers/pollers.go

@@ -23,9 +23,10 @@ const (
 )
 
 const (
-	statusSucceeded = "succeeded"
-	statusCanceled  = "canceled"
-	statusFailed    = "failed"
+	StatusSucceeded  = "Succeeded"
+	StatusCanceled   = "Canceled"
+	StatusFailed     = "Failed"
+	StatusInProgress = "InProgress"
 )
 
 // reads the response body into a raw JSON object.
@@ -85,12 +86,12 @@ func status(jsonBody map[string]interface{}) string {
 
 // IsTerminalState returns true if the LRO's state is terminal.
 func IsTerminalState(s string) bool {
-	return strings.EqualFold(s, statusSucceeded) || strings.EqualFold(s, statusFailed) || strings.EqualFold(s, statusCanceled)
+	return strings.EqualFold(s, StatusSucceeded) || strings.EqualFold(s, StatusFailed) || strings.EqualFold(s, StatusCanceled)
 }
 
 // Failed returns true if the LRO's state is terminal failure.
 func Failed(s string) bool {
-	return strings.EqualFold(s, statusFailed) || strings.EqualFold(s, statusCanceled)
+	return strings.EqualFold(s, StatusFailed) || strings.EqualFold(s, StatusCanceled)
 }
 
 // GetStatus returns the LRO's status from the response body.

sdk/armcore/poller.go

@@ -294,7 +294,7 @@ func (*nopPoller) FinalGetURL() string {
 }
 
 func (*nopPoller) Status() string {
-	return "Succeeded"
+	return pollers.StatusSucceeded
 }
 
 // returns true if the LRO response contains a valid HTTP status code