Add retries to tests relying on Http bin to improve test resiliency. #5692
Conversation
ahsonkhan
added
Azure.Core
test-reliability
ahsonkhan
requested review from
RickWinter,
antkmsft,
gearama and
LarryOsterman
as code owners
| // is still flagged as shutdown. | ||
| auto session | ||
| = std::make_unique<Azure::Core::Http::CurlSession>(req, std::move(connection), options); | ||
| GTEST_LOG_(INFO) << "forceConnectionClosed test iteration " << i << "."; |
There was a problem hiding this comment.
All of these appear to be essentially identical. Is it possible to centralize this logic in a single function that encapsulates the retry logic and includes the test-specific behavior in a lambda?
There was a problem hiding this comment.
I want to centralize the logic, but I prefer tests to be very simple/isolated and find the readability of lambdas a bit cognitively burdensome. If I can't find a simpler way to achieve that, will fall back to the lambda approach.
| @@ -23,6 +23,10 @@ namespace Azure { namespace Core { namespace Test { | |||
| namespace _detail { | |||
| constexpr static const char AzureSdkHttpbinServerSchema[] = "https"; | |||
| constexpr static const char AzureSdkHttpbinServer[] = "azuresdkforcpp.azurewebsites.net"; | |||
There was a problem hiding this comment.
Should this logic be moved into a single source rather than being defined in two different places?
There was a problem hiding this comment.
Yeah, that's a good suggestion. I will see how to remove the existing duplication here.
|
Hi @ahsonkhan. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @ahsonkhan. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Address a class of intermittent test failures due to transient failures caused by the reliability of http bin.
The issues below have more detail on the intermittent nature of the tests.
Fixes:
#5652
#5006
#4634
#5493
Similar fix to #5537