Skip to content

The _detail and _internal namespace should be the last one in the chain of namespace following SDK design precedence #6120

New issue
New issue
Open
Open
The _detail and _internal namespace should be the last one in the chain of namespace following SDK design precedence#6120

Description

@ahsonkhan

ahsonkhan
openedon Oct 22, 2024

We currently have types in headers that are in the _detail namespace which contain sub-namespaces like Cryptography.

azure-sdk-for-cpp/sdk/tables/azure-data-tables/inc/azure/data/tables/internal/cryptography/url_encode.hpp

Line 12 in 0e699e4

namespace Azure { namespace Data { namespace Tables { namespace _detail { namespace Cryptography {

The existing precedence in the SDK is that _detail/_internal is the last component of the namespace.
See examples:

azure-sdk-for-cpp/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp

Line 18 in 0e699e4

namespace Azure { namespace Core { namespace Cryptography { namespace _internal {

azure-sdk-for-cpp/sdk/core/azure-core/inc/azure/core/internal/credentials/authorization_challenge_parser.hpp

Lines 15 to 16 in 0e699e4

namespace Azure { namespace Core { namespace Credentials {
namespace _detail {

cc @RickWinter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Tables

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions