Fix crash in ESP32 when Azure IoT layer triggers a SAS token refresh #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash was caused because the handle to the MQTT client was being incorrectly passed to esp_mqtt_client_stop (indirection bug). Also removed setting the ESP MQTT buffer size, letting it use its default value. These are the stacktraces of the crashes that this change fixes: Decoding 10 results 0x40083859: panic_abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/panic.c line 402 0x4008db61: esp_system_abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/esp_system.c line 129 0x40092d49: __assert_func at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/assert.c line 85 0x4008eac1: xQueueSemaphoreTake at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/freertos/queue.c line 1549 (discriminator 1) 0x4008ec70: xQueueTakeMutexRecursive at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/freertos/queue.c line 731 0x40106f0a: esp_mqtt_client_stop at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/mqtt/esp-mqtt/mqtt_client.c line 1584 0x400d4829: mqtt_client_deinit_function(void*) at C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino line 187 0x400d4411: azure_iot_do_work(azure_iot_t_struct*) at C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/AzureIoT.cpp line 517 0x400d4f10: loop() at C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino line 421 0x400df8c5: loopTask(void*) at C:\Users\ewertons\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.1\cores\esp32/main.cpp line 46 Decoding 13 results 0x40083859: panic_abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/panic.c line 402 0x4008db61: esp_system_abort at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/esp_system.c line 129 0x40092d49: __assert_func at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/assert.c line 85 0x4009298f: multi_heap_free at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/heap/multi_heap_poisoning.c line 253 : (inlined by) multi_heap_free at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/heap/multi_heap_poisoning.c line 245 0x40083eb5: heap_caps_free at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/heap/heap_caps.c line 305 0x40092d79: free at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/heap.c line 46 0x401111e1: esp_transport_esp_tls_destroy at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/tcp_transport/transport_ssl.c line 458 0x4011097b: esp_transport_destroy_foundation_transport at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/tcp_transport/transport.c line 73 : (inlined by) esp_transport_list_destroy at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/tcp_transport/transport.c line 132 0x40106ff6: esp_mqtt_client_destroy at /Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/mqtt/esp-mqtt/mqtt_client.c line 819 0x400d4847: mqtt_client_deinit_function(void*) at C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino line 194 0x400d433d: azure_iot_do_work(azure_iot_t_struct*) at C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/AzureIoT.cpp line 420 0x400d4f10: loop() at C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino line 421 0x400df8c5: loopTask(void*) at C:\Users\ewertons\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.1\cores\esp32/main.cpp line 46
ewertons
requested review from
danewalton-msft,
wduraes,
ericwolz,
momuno,
mamokarz and
CIPop
danewalton-msft
approved these changes
Jan 20, 2022
examples/Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino
Show resolved
Hide resolved
ericwolz
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash was caused because the handle to the MQTT client was being
incorrectly passed to esp_mqtt_client_stop (indirection bug).
Also removed setting the ESP MQTT buffer size, letting it use its
default value.
These are the stacktraces of the crashes that this change fixes:
Decoding 10 results
0x40083859: panic_abort at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/panic.c
line 402
0x4008db61: esp_system_abort at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/esp_system.c
line 129
0x40092d49: __assert_func at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/assert.c
line 85
0x4008eac1: xQueueSemaphoreTake at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/freertos/queue.c
line 1549 (discriminator 1)
0x4008ec70: xQueueTakeMutexRecursive at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/freertos/queue.c
line 731
0x40106f0a: esp_mqtt_client_stop at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/mqtt/esp-mqtt/mqtt_client.c
line 1584
0x400d4829: mqtt_client_deinit_function(void*) at
C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino
line 187
0x400d4411: azure_iot_do_work(azure_iot_t_struct*) at
C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/AzureIoT.cpp
line 517
0x400d4f10: loop() at
C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino
line 421
0x400df8c5: loopTask(void*) at
C:\Users\ewertons\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.1\cores\esp32/main.cpp
line 46
Decoding 13 results
0x40083859: panic_abort at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/panic.c
line 402
0x4008db61: esp_system_abort at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/esp_system/esp_system.c
line 129
0x40092d49: __assert_func at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/assert.c
line 85
0x4009298f: multi_heap_free at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/heap/multi_heap_poisoning.c
line 253
: (inlined by) multi_heap_free at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/heap/multi_heap_poisoning.c
line 245
0x40083eb5: heap_caps_free at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/heap/heap_caps.c
line 305
0x40092d79: free at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/newlib/heap.c
line 46
0x401111e1: esp_transport_esp_tls_destroy at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/tcp_transport/transport_ssl.c
line 458
0x4011097b: esp_transport_destroy_foundation_transport at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/tcp_transport/transport.c
line 73
: (inlined by) esp_transport_list_destroy at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/tcp_transport/transport.c
line 132
0x40106ff6: esp_mqtt_client_destroy at
/Users/ficeto/Desktop/ESP32/ESP32S2/esp-idf-public/components/mqtt/esp-mqtt/mqtt_client.c
line 819
0x400d4847: mqtt_client_deinit_function(void*) at
C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino
line 194
0x400d433d: azure_iot_do_work(azure_iot_t_struct*) at
C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/AzureIoT.cpp
line 420
0x400d4f10: loop() at
C:\code\s1\azure-sdk-for-c-arduino\examples\Azure_IoT_Central_ESP32_AzureIoTKit/Azure_IoT_Central_ESP32_AzureIoTKit.ino
line 421
0x400df8c5: loopTask(void*) at
C:\Users\ewertons\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.1\cores\esp32/main.cpp
line 46