-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run chat preview4 swagger #582
Merged
marche0133
merged 11 commits into
Azure:feature/AzureCommunication_PostGAReview
from
marche0133:marc/chat-preview4-changes
Feb 23, 2021
Merged
Run chat preview4 swagger #582
marche0133
merged 11 commits into
Azure:feature/AzureCommunication_PostGAReview
from
marche0133:marc/chat-preview4-changes
Feb 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marche0133
commented
Feb 17, 2021
- Change remove participant API to /chat/threads/{chatThreadId}/participants/:remove
- user id in following classes changes from type CommunicationUserIdentifier to type CommunicationIdentifierModel
- property initiator in ChatMessageContent renamed to initiatorCommunicationIdentifier
- property senderId in ChatMessage and ChatMessageReadReceipt renamed to senderCommunicationIdentifier
- property identifier in ChatParticipant renamed to communicationIdentifier
- property createdBy in ChatThread renamed to createdByCommunicationIdentifier
- repeatability-Request-ID in header renamed to repeatability-Request-Id
* Hide the package which set to true instead of putting to Other page * Hide the package not showing in csv * Added logging message * fix the variable * leave an extra space * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Add PrepareRelease Script * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Change GeneralReleaseNotesParser logic * Change GeneralReleaseNotesParser.ps1 logic * Remoce GeneralReleaseNotesParsercopy * Update collect changelog and generalreleasenotes parser logic * Refine CollectChangelog Logic * Add logic for filtering collected changelog * Add Filter-ReleaseHighlights function * Update General ReleasNotes Logic * Delete GeneralReleaseNotesLogic.ps1 * Update Collect ChangeLogLogic Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Extend Get-GitHubPullRequest to return only files * Add check to prevent eng/common changes that are not proper syncs * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Minnie Liu <peiliu@microsoft.com>
- Change remove participant API to /chat/threads/{chatThreadId}/participants/:remove - user id in following classes changes from type CommunicationUserIdentifier to type CommunicationIdentifierModel - property initiator in ChatMessageContent renamed to initiatorCommunicationIdentifier - property senderId in ChatMessage and ChatMessageReadReceipt renamed to senderCommunicationIdentifier - property identifier in ChatParticipant renamed to communicationIdentifier - property createdBy in ChatThread renamed to createdByCommunicationIdentifier - repeatability-Request-ID in header renamed to repeatability-Request-Id
ghost
added
the
Communication
label
Feb 17, 2021
marche0133
changed the base branch from
master
to
feature/AzureCommunication_PostGAReview
February 18, 2021 00:42
JianpingChen
requested changes
Feb 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you changing files under /eng?
...at/src/main/java/com/azure/android/communication/chat/CommunicationIdentifierSerializer.java
Show resolved
Hide resolved
...c/test/java/com/azure/android/communication/chat/CommunicationIdentifierSerializerTests.java
Show resolved
Hide resolved
Those are auto changes by Azure Bot |
JianpingChen
approved these changes
Feb 23, 2021
marche0133
added a commit
that referenced
this pull request
Mar 8, 2021
* Run chat preview4 swagger (#582) * Sync eng/common directory with azure-sdk-tools for PR 1393 (#566) * Hide the package which set to true instead of putting to Other page * Hide the package not showing in csv * Added logging message * fix the variable * leave an extra space * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 1303 (#569) * Add PrepareRelease Script * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Change GeneralReleaseNotesParser logic * Change GeneralReleaseNotesParser.ps1 logic * Remoce GeneralReleaseNotesParsercopy * Update collect changelog and generalreleasenotes parser logic * Refine CollectChangelog Logic * Add logic for filtering collected changelog * Add Filter-ReleaseHighlights function * Update General ReleasNotes Logic * Delete GeneralReleaseNotesLogic.ps1 * Update Collect ChangeLogLogic Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 1358 (#571) * Extend Get-GitHubPullRequest to return only files * Add check to prevent eng/common changes that are not proper syncs * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Enable passing devops pat for work item scripts (#573) Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * Change script parameters to boolean (#574) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * Generating Identifier Models (#577) Co-authored-by: Minnie Liu <peiliu@microsoft.com> * Run swagger preview4 - Change remove participant API to /chat/threads/{chatThreadId}/participants/:remove - user id in following classes changes from type CommunicationUserIdentifier to type CommunicationIdentifierModel - property initiator in ChatMessageContent renamed to initiatorCommunicationIdentifier - property senderId in ChatMessage and ChatMessageReadReceipt renamed to senderCommunicationIdentifier - property identifier in ChatParticipant renamed to communicationIdentifier - property createdBy in ChatThread renamed to createdByCommunicationIdentifier - repeatability-Request-ID in header renamed to repeatability-Request-Id * Move test to chat package * Move tests to chat package * Update readme broken link * Minor update 'changes' to 'changed' Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Marc Ma <marcma@microsoft.com> * Update readme * Create signaling package to integrate Android chat SDK with trouter client to receive realtime messages (#567) * Create signaling package to integrate Android chat SDK with trouter client. Receive real-time notifications through trouter. * Changes according to feedback Add trouter-client-android 0.0.1 * Fix import package * Add a listenerId as a reference to added listeners Fix a parse bug * Update readme broken link * Removed extra License header Co-authored-by: Marc Ma <marcma@microsoft.com> Co-authored-by: vcolin7 <vicolina@microsoft.com> * Add real time notification test app (#604) * Create signaling package to integrate Android chat SDK with trouter client. Receive real-time notifications through trouter. * Changes according to feedback Add trouter-client-android 0.0.1 * Fix import package * Add a listenerId as a reference to added listeners Fix a parse bug * Add real time notification test app * Update versioon number * Use absolute path for ext import * Update version in both packages' CHANGELOG.md and build.gradle * Minor update according to feedback * Minor update the placeholders Co-authored-by: Marc Ma <marcma@microsoft.com> * [Communication] - Token - Introduce CommunicationAccessToken (#612) * Generating Identifier Models (#577) Co-authored-by: Minnie Liu <peiliu@microsoft.com> * [CommunicationAccessToken] Introducing communication access token * [Communication] introduce CommunicationAccessToken * [Core] removing the core from gradle and fixing up any errors. moving the serializer tests to chat * [AutoRefreshUserCredential] removing the logger with Log.w * [Changelog] adding the new breaking changes to change log * Update sdk/communication/azure-communication-common/CHANGELOG.md Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com> * Update sdk/communication/azure-communication-common/CHANGELOG.md Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com> * [MicrosoftTeamsUserIdentifier] logic fix for user id null check * [Identifier] fixing null and empty logic Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com> * [Identifier] fixing the logic to be same as core utils (#616) * Update version number to 1.0.1 * Change version back to beta Add changes history into CHANGELOG.md * Remove a TODO * Update CHANGELOG.md Remove swagger.json Remove a duplication description * Remove aar and use remote maven package for trouter client Extrac trouter config into prod and test properties config files Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Marc Ma <marcma@microsoft.com> Co-authored-by: vcolin7 <vicolina@microsoft.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com>
anuchandy
pushed a commit
to anuchandy/azure-sdk-for-android-1
that referenced
this pull request
Mar 26, 2021
* Run chat preview4 swagger (Azure#582) * Sync eng/common directory with azure-sdk-tools for PR 1393 (Azure#566) * Hide the package which set to true instead of putting to Other page * Hide the package not showing in csv * Added logging message * fix the variable * leave an extra space * Update eng/common/docgeneration/Generate-DocIndex.ps1 Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Sync eng/common directory with azure-sdk-tools for PR 1303 (Azure#569) * Add PrepareRelease Script * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Change GeneralReleaseNotesParser logic * Change GeneralReleaseNotesParser.ps1 logic * Remoce GeneralReleaseNotesParsercopy * Update collect changelog and generalreleasenotes parser logic * Refine CollectChangelog Logic * Add logic for filtering collected changelog * Add Filter-ReleaseHighlights function * Update General ReleasNotes Logic * Delete GeneralReleaseNotesLogic.ps1 * Update Collect ChangeLogLogic Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 1358 (Azure#571) * Extend Get-GitHubPullRequest to return only files * Add check to prevent eng/common changes that are not proper syncs * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Enable passing devops pat for work item scripts (Azure#573) Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * Change script parameters to boolean (Azure#574) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> * Generating Identifier Models (Azure#577) Co-authored-by: Minnie Liu <peiliu@microsoft.com> * Run swagger preview4 - Change remove participant API to /chat/threads/{chatThreadId}/participants/:remove - user id in following classes changes from type CommunicationUserIdentifier to type CommunicationIdentifierModel - property initiator in ChatMessageContent renamed to initiatorCommunicationIdentifier - property senderId in ChatMessage and ChatMessageReadReceipt renamed to senderCommunicationIdentifier - property identifier in ChatParticipant renamed to communicationIdentifier - property createdBy in ChatThread renamed to createdByCommunicationIdentifier - repeatability-Request-ID in header renamed to repeatability-Request-Id * Move test to chat package * Move tests to chat package * Update readme broken link * Minor update 'changes' to 'changed' Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Marc Ma <marcma@microsoft.com> * Update readme * Create signaling package to integrate Android chat SDK with trouter client to receive realtime messages (Azure#567) * Create signaling package to integrate Android chat SDK with trouter client. Receive real-time notifications through trouter. * Changes according to feedback Add trouter-client-android 0.0.1 * Fix import package * Add a listenerId as a reference to added listeners Fix a parse bug * Update readme broken link * Removed extra License header Co-authored-by: Marc Ma <marcma@microsoft.com> Co-authored-by: vcolin7 <vicolina@microsoft.com> * Add real time notification test app (Azure#604) * Create signaling package to integrate Android chat SDK with trouter client. Receive real-time notifications through trouter. * Changes according to feedback Add trouter-client-android 0.0.1 * Fix import package * Add a listenerId as a reference to added listeners Fix a parse bug * Add real time notification test app * Update versioon number * Use absolute path for ext import * Update version in both packages' CHANGELOG.md and build.gradle * Minor update according to feedback * Minor update the placeholders Co-authored-by: Marc Ma <marcma@microsoft.com> * [Communication] - Token - Introduce CommunicationAccessToken (Azure#612) * Generating Identifier Models (Azure#577) Co-authored-by: Minnie Liu <peiliu@microsoft.com> * [CommunicationAccessToken] Introducing communication access token * [Communication] introduce CommunicationAccessToken * [Core] removing the core from gradle and fixing up any errors. moving the serializer tests to chat * [AutoRefreshUserCredential] removing the logger with Log.w * [Changelog] adding the new breaking changes to change log * Update sdk/communication/azure-communication-common/CHANGELOG.md Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com> * Update sdk/communication/azure-communication-common/CHANGELOG.md Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com> * [MicrosoftTeamsUserIdentifier] logic fix for user id null check * [Identifier] fixing null and empty logic Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com> * [Identifier] fixing the logic to be same as core utils (Azure#616) * Update version number to 1.0.1 * Change version back to beta Add changes history into CHANGELOG.md * Remove a TODO * Update CHANGELOG.md Remove swagger.json Remove a duplication description * Remove aar and use remote maven package for trouter client Extrac trouter config into prod and test properties config files Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Sima Zhu <sizhu@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: minnieliu <minnieliu96@hotmail.com> Co-authored-by: Minnie Liu <peiliu@microsoft.com> Co-authored-by: Marc Ma <marcma@microsoft.com> Co-authored-by: vcolin7 <vicolina@microsoft.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: Jianping Chen <jp.chen.jianping@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.