Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse DataPlane]Add a property as required and Remove AccessControl's operation id #9899

Merged

Conversation

aim-for-better
Copy link
Member

@aim-for-better aim-for-better commented Jun 20, 2020

  1. Add a property as required
  2. Remove AccessControl's operation id to elevate methods to client

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

2. Remove AccessControl's operation id to elevate methods to client
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 20, 2020

[Staging] Swagger Validation Report

BreakingChange: 9 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_DeleteRoleAssignmentById' to 'DeleteRoleAssignmentById'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L157:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L157:7
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_GetRoleAssignmentById' to 'GetRoleAssignmentById'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L119:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L119:7
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_GetRoleDefinitions' to 'GetRoleDefinitions'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roles.json#L21:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roles.json#L21:7
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_GetCallerRoleAssignments' to 'GetCallerRoleAssignments'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L197:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L197:7
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_CreateRoleAssignment' to 'CreateRoleAssignment'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L21:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L21:7
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_GetRoleAssignments' to 'GetRoleAssignments'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L67:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roleAssignments.json#L67:7
1008 - ModifiedOperationId The operation id has been changed from 'AccessControl_GetRoleDefinitionById' to 'GetRoleDefinitionById'. This will impact generated code.
New: Microsoft.Synapse/preview/2020-02-01-preview/roles.json#L61:7
Old: Microsoft.Synapse/preview/2020-02-01-preview/roles.json#L61:7
1034 - AddedRequiredProperty The new version has new required property 'commandPayload' that was not found in the old version.
New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1559:13
Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L1559:13
1034 - AddedRequiredProperty The new version has new required property 'commandPayload' that was not found in the old version.
New: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2697:5
Old: Microsoft.Synapse/preview/2019-06-01-preview/artifacts.json#L2697:5
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 20, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lmazuel lmazuel merged commit 5703951 into Azure:master Jun 22, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits)
  Update DeletionRecovery Level (Azure#9895)
  Updating operations API to enable metrics via public metrics REST API. (Azure#9918)
  Xynoclafe/2020 06 version (Azure#9888)
  update java md (Azure#9923)
  Compute 2020-06-01 API version (Azure#9167)
  Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914)
  new Batch Document Translation API Preview 1.0 (Azure#9218)
  1. Add a property as required (Azure#9899)
  Operational insights delete wrong lines data export (Azure#9849)
  [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831)
  [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838)
  add Java to AVS (Azure#9855)
  LaMigrationDate (Azure#9882)
  change vmware client name to AVSClient (Azure#9863)
  Fix typo in common private links definition for actionsRequired (Azure#9727)
  Microsoft.Support RP documentation updates (Azure#9880)
  BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868)
  Update ci-fix.md (Azure#9881)
  Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819)
  update java readme digitaltwins (Azure#9878)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
2. Remove AccessControl's operation id to elevate methods to client

Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants