Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checklist] Clarify Mnnnn or Snnnn are unique #983

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

RobDolinMS
Copy link
Contributor

@RobDolinMS RobDolinMS commented Mar 2, 2017

Per discussion with @fearthecowboy and others, "nnnn" alone will not be unique but "Mnnnn" or "Snnnn" will be unique.

Also formats that paragraph with one sentence per line for readability.

Signed-off-by: Rob Dolin robdolin@microsoft.com

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

  • I have read the contribution guidelines.
  • My spec meets the review criteria:
    • The spec conforms to the Swagger 2.0 specification.
    • Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
    • The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.

Per discussion with @fearthecowboy and others, "nnnn" alone will not be unique but "Mnnnn" or "Snnnn" will be unique.

Also formats that paragraph with one sentence per line for readability.  

Signed-off-by: Rob Dolin <robdolin@microsoft.com>
@msftclas
Copy link

msftclas commented Mar 2, 2017

@RobDolinMS,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@sarangan12
Copy link
Member

Thanks for submitting this. I will review this and get back to you shortly

@sarangan12 sarangan12 merged commit 651ce58 into Azure:master Mar 3, 2017
@AutorestCI
Copy link

No modification for Python

@AutorestCI
Copy link

No modification for Ruby

@AutorestCI
Copy link

No modification for NodeJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants